Skip to content
Snippets Groups Projects

Fix bug: missing call to MergeRequest.find in Notify#changed_merge_request_email

Merged Fix bug: missing call to MergeRequest.find in Notify#changed_merge_request_email
github/fork/robbkidd/add_missing_call_to_find into master
Merged gitlab-qa-bot requested to merge github/fork/robbkidd/add_missing_call_to_find into master

Created by: robbkidd

Bug in the move to resque_mailer. I found this while adding mailer specs for Notify. Would you guys be interested in my submitting the specs in a pull request?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    Yes we are interested in specs

    By Administrator on 2012-05-15T07:17:34 (imported from GitLab project)

    By Administrator on 2012-05-15T07:17:34 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: robbkidd

    Working on it! https://github.com/robbkidd/gitlabhq/tree/test_the_mailers

    By Administrator on 2012-05-15T07:47:26 (imported from GitLab project)

    By Administrator on 2012-05-15T07:47:26 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    @robbkidd waiting for PR :)

    By Administrator on 2012-05-15T07:54:30 (imported from GitLab project)

    By Administrator on 2012-05-15T07:54:30 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: robbkidd

    Yea. The first draft of them were written prior to the introduction of rescue_mailer. They are not all green against latest master, yet.

    By Administrator on 2012-05-15T10:32:37 (imported from GitLab project)

    By Administrator on 2012-05-15T10:32:37 (imported from GitLab)

Please register or sign in to reply