Green "Accept merge request" is dangerous
Created by: coder-hugo
Since a few months we are using GitLab at work to mange our projects. For reviewing the code we use the merge request feature which is very helpful. But it happened more than once that the reviewer hit accidentally the button "Accept merge request" after modifying the assignee or the milestone. This happens because of several UX issues.
- You won't get notified that your changes regarding the assignee or the milestone have been saved automatically.
- There is no confirmation dialog before performing the auto-merge.
- The color of button is green. As the action behind this button usually will modify your master the button should be red or similar to give the user a fair waring that the action of this button is "dangerous".
IMHO the easiest solution for this issues would be the color change of the button. But I think that a confirmation dialog for such an action should be essential.