LDAP users can't login if username contain special characters

Created by: cypx

Users with password containing special characters can't login.

login page return an error message:

Could not authorize you from Ldap because "Undefined method `is admin?' for nil:nilclass

Gitlab log shows this:

Started GET "/assets/login-logo-1d5c7538990a9248549eb99278fc6bf2.png" for 127.0.0.1 at 2012-10-01 11:43:46 +0200 Served asset /login-logo-1d5c7538990a9248549eb99278fc6bf2.png - 304 Not Modified (0ms) Processing by OmniauthCallbacksController#ldap as HTML Parameters: {"utf8"=>"✓", "authenticity_token"=>"TOKEN_REMOVED", "username"=>"USERNAME_REMOVED", "password"=>"[FILTERED]"} Rendered errors/encoding.html.haml within layouts/error (1.5ms) Rendered layouts/_head.html.haml (1.8ms) Rendered layouts/_flash.html.haml (0.2ms) Rendered layouts/_head_panel.html.haml (2.7ms) Completed 500 Internal Server Error in 29ms Processing by OmniauthCallbacksController#failure as HTML Parameters: {"utf8"=>"✓", "authenticity_token"=>"TOKEN_REMOVED", "username"=>"USERNAME_REMOVED", "password"=>"[FILTERED]"} Redirected to http://URL_REMOVED/users/sign_in Completed 302 Found in 3ms (ActiveRecord: 0.0ms)

Started POST "/users/auth/ldap/callback" for 127.0.0.1 at 2012-10-01 11:44:00 +0200 Processing by OmniauthCallbacksController#ldap as HTML Parameters: {"utf8"=>"✓", "authenticity_token"=>"TOKEN_REMOVED", "username"=>"USERNAME_REMOVED", "password"=>"[FILTERED]"} Rendered errors/encoding.html.haml within layouts/error (1.5ms) Rendered layouts/_head.html.haml (1.8ms) Rendered layouts/_flash.html.haml (0.2ms) Rendered layouts/_head_panel.html.haml (8.9ms) Completed 500 Internal Server Error in 47ms Processing by OmniauthCallbacksController#failure as HTML Parameters: {"utf8"=>"✓", "authenticity_token"=>"TOKEN_REMOVED", "username"=>"USERNAME_REMOVED", "password"=>"[FILTERED]"} Redirected to http://URL_REMOVED/users/sign_in Completed 302 Found in 3ms (ActiveRecord: 0.0ms)

No problem for other users. Version 2.9.1

EDIT: replace password by username