Browser back button breaks "Loading..." visual
Created by: chrisls121
Summary
When using the back button in the browser, the "Loading..." visual appears but doesn't get removed on successful page load.
Steps to reproduce
- Log in to GitLab
- Browse to the Help page
- Use the back button in your browser
Using Chrome Version 30.0.1599.101 m
Expected behavior
"Loading ..." visual is removed on successful page load.
Observed behavior
"Loading ..." visual is not removed on successful page load.
Output of checks
GitLab Application Check
Checking Environment ...
Git configured for git user? ... yes
Has python2? ... yes
python2 is supported version? ... yes
Checking Environment ... Finished
Checking GitLab Shell ...
GitLab Shell version >= 1.7.1 ? ... OK (1.7.1)
Repo base directory exists? ... yes
Repo base directory is a symlink? ... no
Repo base owned by git:git? ... yes
Repo base access is drwxrws---? ... yes
update hook up-to-date? ... yes
update hooks in repos are links: ...
*** / *** ... ok
Running /home/git/gitlab-shell/bin/check
Check GitLab API access: OK
Check directories and files:
/home/git/repositories: OK
/home/git/.ssh/authorized_keys: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking GitLab ...
Database config exists? ... yes
Database is SQLite ... no
All migrations up? ... yes
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Init script exists? ... yes
Init script up-to-date? ... yes
projects have namespace: ...
*** / *** ... yes
Projects have satellites? ...
*** / *** ... yes
Redis version >= 2.0.0? ... yes
Your git bin path is "/usr/bin/git"
Git version >= 1.7.10 ? ... yes (1.8.3)
Checking GitLab ... Finished
GitLab Version Check
System information
System: Ubuntu 13.10
Current User: git
Using RVM: no
Ruby Version: 2.0.0p247
Gem Version: 2.1.9
Bundler Version:1.3.5
Rake Version: 10.1.0
GitLab information
Version: 6.2.1
Revision: f2a77a8
Directory: /home/git/gitlab
DB Adapter: mysql2
URL: https://gitlab.***.***
HTTP Clone URL: https://gitlab.***.***/some-project.git
SSH Clone URL: git@gitlab.***.***:some-project.git
Using LDAP: no
Using Omniauth: no
GitLab Shell
Version: 1.7.1
Repositories: /home/git/repositories/
Hooks: /home/git/gitlab-shell/hooks/
Git: /usr/bin/git