Skip to content

Remove empty lines at the of file when edit a file via web browser

Created by: okkez

Summary

  • GitLab 6.4.3
  • GitLab Shell 1.8.0
  • GitLab API v3
  • Ruby 1.9.3p484
  • Rails 4.0.2

I have editted my repo's file via web browsers.

  • Chromium 31.0.1650.63 Debian jessie/sid (238485)
  • Iceweasel 24.2.0

Then GitLab removed empty lines at the end of file.

Steps to reproduce

(1) Add a new file via git command It has some contents and empty lines at the end of file. (2) Edit the file which is added by step 1 via GitLab's editor NOTE:GitLab ignores empty lines at the end of file when it displays the target file on web browser. (3) Pull changes via git and check editted file. We can find broken file which has no empty lines at the end of file.

Expected result

Do not remove empty lines at the end of file when we edit the file via GitLab's editor.

Observed behavior

Remove empty lines at the end of file when we edit the file via GitLab's editor.