Merge branch...

Merge branch 'mark_obsolete-20240201164432--reindex-merge-request-to-update-analyzer' into 'master' 

Mark 20240201164432 as obsolete

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/169308



Merged-by: Arturo Herrero <arturo.herrero@gmail.com>
Approved-by: Arturo Herrero <arturo.herrero@gmail.com>
Co-authored-by: Ravi Kumar <rkumar@gitlab.com>
Co-authored-by: Terri Chu <tchu@gitlab.com>

ee/elastic/docs/20240201164432_reindex_merge_request_to_update_analyzer.yml

 ---
 name: ReindexMergeRequestToUpdateAnalyzer
 version: '20240201164432'
-description: This migration reindexes the merge_requests index to start using new analyzers for description and title
+description: This migration reindexes the merge_requests index to start using new
+  analyzers for description and title
 group: group::global search
 milestone: '16.9'
 introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/142550
-obsolete: false
-marked_obsolete_by_url:
-marked_obsolete_in_milestone:
+obsolete: true
+marked_obsolete_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/169308
+marked_obsolete_in_milestone: '17.6'

ee/elastic/migrate/20240201164432_reindex_merge_request_to_update_analyzer.rb

@@ -9,3 +9,5 @@ def completed?
     true
   end
 end
+
+ReindexMergeRequestToUpdateAnalyzer.prepend ::Elastic::MigrationObsolete

ee/spec/elastic/migrate/20240201164432_reindex_merge_request_to_update_analyzer_spec.rb

@@ -4,26 +4,5 @@
 require File.expand_path('ee/elastic/migrate/20240201164432_reindex_merge_request_to_update_analyzer.rb')
 RSpec.describe ReindexMergeRequestToUpdateAnalyzer, feature_category: :global_search do
-  let(:version) { 20240201164432 }
-  let(:migration) { described_class.new(version) }
-
-  it 'does not have migration options set', :aggregate_failures do
-    expect(migration).not_to be_batched
-    expect(migration).not_to be_retry_on_failure
-  end
-
-  describe '#migrate' do
-    it 'creates reindexing task with correct target and options' do
-      expect { migration.migrate }.to change { Elastic::ReindexingTask.count }.by(1)
-      task = Elastic::ReindexingTask.last
-      expect(task.targets).to eq(%w[MergeRequest])
-      expect(task.options).to eq({ 'skip_pending_migrations_check' => true })
-    end
-  end
-
-  describe '#completed?' do
-    it 'always returns true' do
-      expect(migration.completed?).to eq(true)
-    end
-  end
+  it_behaves_like 'a deprecated Advanced Search migration', 20240201164432
 end