Merge branch '214541-cngo-remove-manual-sort-option' into 'master'

Remove Manual sort option from issues dashboard page

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/169158



Merged-by: Coung Ngo <cngo@gitlab.com>
Approved-by: Martin Čavoj <mcavoj@gitlab.com>
Approved-by: Scott de Jonge <sdejonge@gitlab.com>
Reviewed-by: Coung Ngo <cngo@gitlab.com>
Reviewed-by: Martin Čavoj <mcavoj@gitlab.com>

app/assets/javascripts/issues/dashboard/components/issues_dashboard_app.vue

@@ -354,6 +354,7 @@ export default {
         hasBlockedIssuesFeature: this.hasBlockedIssuesFeature,
         hasIssuableHealthStatusFeature: this.hasIssuableHealthStatusFeature,
         hasIssueWeightsFeature: this.hasIssueWeightsFeature,
+        hasManualSort: false,
       });
     },
     tabCounts() {

spec/frontend/issues/dashboard/components/issues_dashboard_app_spec.js

@@ -130,36 +130,55 @@ describe('IssuesDashboardApp component', () => {
       await waitForPromises();
     });
-    // quarantine: https://gitlab.com/gitlab-org/gitlab/-/issues/391722
-    // eslint-disable-next-line jest/no-disabled-tests
-    it.skip('renders IssuableList component', () => {
-      expect(findIssuableList().props()).toMatchObject({
-        currentTab: STATUS_OPEN,
-        hasNextPage: true,
-        hasPreviousPage: false,
-        hasScopedLabelsFeature: defaultProvide.hasScopedLabelsFeature,
-        initialSortBy: CREATED_DESC,
-        issuables: issuesQueryResponse.data.issues.nodes,
-        issuablesLoading: false,
-        namespace: 'dashboard',
-        recentSearchesStorageKey: 'issues',
-        showPaginationControls: true,
-        sortOptions: getSortOptions({
-          hasBlockedIssuesFeature: defaultProvide.hasBlockedIssuesFeature,
-          hasIssuableHealthStatusFeature: defaultProvide.hasIssuableHealthStatusFeature,
-          hasIssueWeightsFeature: defaultProvide.hasIssueWeightsFeature,
-        }),
-        tabCounts: {
+    describe('IssuableList component', () => {
+      it('renders', () => {
+        expect(findIssuableList().props()).toMatchObject({
+          currentTab: STATUS_OPEN,
+          hasNextPage: true,
+          hasPreviousPage: false,
+          hasScopedLabelsFeature: true,
+          initialSortBy: CREATED_DESC,
+          namespace: 'dashboard',
+          recentSearchesStorageKey: 'issues',
+          showPaginationControls: true,
+          showWorkItemTypeIcon: true,
+          truncateCounts: true,
+          useKeysetPagination: true,
+        });
+      });
+
+      it('renders issues', () => {
+        expect(findIssuableList().props('issuables')).toHaveLength(1);
+      });
+
+      it('renders sort options', () => {
+        expect(findIssuableList().props('sortOptions')).toEqual(
+          getSortOptions({
+            hasBlockedIssuesFeature: defaultProvide.hasBlockedIssuesFeature,
+            hasIssuableHealthStatusFeature: defaultProvide.hasIssuableHealthStatusFeature,
+            hasIssueWeightsFeature: defaultProvide.hasIssueWeightsFeature,
+            hasManualSort: false,
+          }),
+        );
+      });
+
+      it('renders tabs', () => {
+        expect(findIssuableList().props('tabs')).toEqual(IssuesDashboardApp.issuableListTabs);
+      });
+
+      it('renders tab counts', () => {
+        expect(findIssuableList().props('tabCounts')).toEqual({
           opened: 1,
           closed: 2,
           all: 3,
-        },
-        tabs: IssuesDashboardApp.issuableListTabs,
-        urlParams: {
+        });
+      });
+
+      it('renders url params', () => {
+        expect(findIssuableList().props('urlParams')).toMatchObject({
           sort: urlSortParams[CREATED_DESC],
           state: STATUS_OPEN,
-        },
-        useKeysetPagination: true,
+        });
       });
     });