From 091142118ee9555544acf6d05f61fd109e400ff2 Mon Sep 17 00:00:00 2001
From: Lin Jen-Shin <godfat@godfat.org>
Date: Wed, 20 Jul 2016 01:08:16 +0800
Subject: [PATCH] Now we could use normal relation, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13173842
---
app/models/project.rb | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/app/models/project.rb b/app/models/project.rb
index 4ba3881d30e..026fff0da0c 100644
--- a/app/models/project.rb
+++ b/app/models/project.rb
@@ -431,8 +431,7 @@ class Project < ActiveRecord::Base
# ref can't be HEAD, can only be branch/tag name or SHA
def latest_successful_builds_for(ref = default_branch)
- Ci::Build.joins(:pipeline).
- merge(pipelines.latest_successful_for(ref)).
+ builds.where(pipeline: pipelines.latest_successful_for(ref)).
latest_successful_with_artifacts
end
--
GitLab