From 1994c0323af72ff9b3667f5d9f45a99ae09986d4 Mon Sep 17 00:00:00 2001
From: Grzegorz Bizon <grzesiek.bizon@gmail.com>
Date: Wed, 4 Jan 2017 12:48:24 +0100
Subject: [PATCH] Add test example for pipeline with yaml errors
---
spec/factories/ci/pipelines.rb | 4 ++++
.../projects/pipelines/pipelines_spec.rb | 18 ++++++++++++++++++
2 files changed, 22 insertions(+)
diff --git a/spec/factories/ci/pipelines.rb b/spec/factories/ci/pipelines.rb
index 6ed4f547d04..77404f46c92 100644
--- a/spec/factories/ci/pipelines.rb
+++ b/spec/factories/ci/pipelines.rb
@@ -36,6 +36,10 @@ FactoryGirl.define do
#
pipeline.config_processor if evaluator.config
end
+
+ trait :invalid do
+ config(rspec: nil)
+ end
end
end
end
diff --git a/spec/features/projects/pipelines/pipelines_spec.rb b/spec/features/projects/pipelines/pipelines_spec.rb
index 574efe351f5..cfc74c140dd 100644
--- a/spec/features/projects/pipelines/pipelines_spec.rb
+++ b/spec/features/projects/pipelines/pipelines_spec.rb
@@ -86,6 +86,24 @@ describe 'Pipelines', :feature, :js do
end
end
+ context 'when pipeline has configuration errors' do
+ let(:pipeline) do
+ create(:ci_pipeline, :invalid, project: project)
+ end
+
+ before { visit_project_pipelines }
+
+ it 'contains badge that indicate errors' do
+ expect(page).to have_content 'yaml invalid'
+ end
+
+ it 'contains badge with tooltip which contains error' do
+ expect(pipeline).to have_yaml_errors
+ expect(page).to have_selector(
+ %Q{span[data-original-title="#{pipeline.yaml_errors}"]})
+ end
+ end
+
context 'with manual actions' do
let!(:manual) do
create(:ci_build, :manual,
--
GitLab