From 1c275a7523e5d891a8d15720386b6119d0cedf41 Mon Sep 17 00:00:00 2001 From: Lin Jen-Shin <godfat@godfat.org> Date: Fri, 23 Dec 2016 18:30:25 +0800 Subject: [PATCH] Update description stating that ordering is important Feedback from Grzegorz --- spec/models/ci/pipeline_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/models/ci/pipeline_spec.rb b/spec/models/ci/pipeline_spec.rb index f5d206e0a3e..b28da6daabf 100644 --- a/spec/models/ci/pipeline_spec.rb +++ b/spec/models/ci/pipeline_spec.rb @@ -424,7 +424,7 @@ describe Ci::Pipeline, models: true do context 'when no ref is specified' do let(:pipelines) { described_class.latest.all } - it 'returns the latest pipelines for the same ref and different sha' do + it 'gives the latest pipelines for the same ref and different sha in reverse chronological order' do expect(pipelines.map(&:sha)).to eq(%w[C B A]) expect(pipelines.map(&:status)).to eq(%w[skipped failed success]) end @@ -433,7 +433,7 @@ describe Ci::Pipeline, models: true do context 'when ref is specified' do let(:pipelines) { described_class.latest('ref').all } - it 'returns the latest pipelines for ref and different sha' do + it 'gives the latest pipelines for ref and different sha in reverse chronological order' do expect(pipelines.map(&:sha)).to eq(%w[B A]) expect(pipelines.map(&:status)).to eq(%w[failed success]) end -- GitLab