From 2de1109da39a46200e741b5a6643ce7fb1418041 Mon Sep 17 00:00:00 2001
From: Robert Speicher <rspeicher@gmail.com>
Date: Mon, 23 May 2016 13:21:02 -0400
Subject: [PATCH] Enable Performance/StartWith cop and fix offenses
---
.rubocop.yml | 3 +--
app/helpers/gitlab_markdown_helper.rb | 2 +-
app/helpers/tab_helper.rb | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/.rubocop.yml b/.rubocop.yml
index 0946ef5d848..861dde41494 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -985,11 +985,10 @@ Performance/RedundantMerge:
Performance/RedundantSortBy:
Enabled: false
-# TODO: Enable StartWith Cop.
# Use `start_with?` instead of a regex match anchored to the beginning of a
# string.
Performance/StartWith:
- Enabled: false
+ Enabled: true
# Use `tr` instead of `gsub` when you are replacing the same number of
# characters. Use `delete` instead of `gsub` when you are deleting
diff --git a/app/helpers/gitlab_markdown_helper.rb b/app/helpers/gitlab_markdown_helper.rb
index 3a45205563e..0a1b48af219 100644
--- a/app/helpers/gitlab_markdown_helper.rb
+++ b/app/helpers/gitlab_markdown_helper.rb
@@ -13,7 +13,7 @@ module GitlabMarkdownHelper
def link_to_gfm(body, url, html_options = {})
return "" if body.blank?
- escaped_body = if body =~ /\A\<img/
+ escaped_body = if body.start_with?('<img')
body
else
escape_once(body)
diff --git a/app/helpers/tab_helper.rb b/app/helpers/tab_helper.rb
index 96a83671009..b4b4d804203 100644
--- a/app/helpers/tab_helper.rb
+++ b/app/helpers/tab_helper.rb
@@ -112,7 +112,7 @@ module TabHelper
end
def profile_tab_class
- if controller.controller_path =~ /\Aprofiles/
+ if controller.controller_path.start_with?('profiles')
return 'active'
end
--
GitLab