From 3ba65185127da07cd82d346fdcf001878b97fd31 Mon Sep 17 00:00:00 2001
From: Grzegorz Bizon <grzesiek.bizon@gmail.com>
Date: Wed, 15 Feb 2017 11:12:07 +0100
Subject: [PATCH] Prefer using `project.add_developer` in specs
---
spec/models/ci/build_spec.rb | 6 +++---
spec/models/ci/pipeline_spec.rb | 4 ++--
spec/services/ci/process_pipeline_service_spec.rb | 2 +-
spec/services/ci/retry_build_service_spec.rb | 4 ++--
spec/services/create_deployment_service_spec.rb | 2 +-
5 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/spec/models/ci/build_spec.rb b/spec/models/ci/build_spec.rb
index 9d5849eeec1..2dfca8bcfce 100644
--- a/spec/models/ci/build_spec.rb
+++ b/spec/models/ci/build_spec.rb
@@ -208,7 +208,7 @@ describe Ci::Build, :models do
end
it 'expects to have retried builds instead the original ones' do
- project.team << [user, :developer]
+ project.add_developer(user)
retried_rspec = Ci::Build.retry(rspec_test, user)
@@ -817,7 +817,7 @@ describe Ci::Build, :models do
subject { build.other_actions }
before do
- project.team << [user, :developer]
+ project.add_developer(user)
end
it 'returns other actions' do
@@ -865,7 +865,7 @@ describe Ci::Build, :models do
let(:build) { create(:ci_build, :manual, pipeline: pipeline) }
before do
- project.team << [user, :developer]
+ project.add_developer(user)
end
context 'when build is manual' do
diff --git a/spec/models/ci/pipeline_spec.rb b/spec/models/ci/pipeline_spec.rb
index 45c710b2381..10c2bfbb400 100644
--- a/spec/models/ci/pipeline_spec.rb
+++ b/spec/models/ci/pipeline_spec.rb
@@ -563,7 +563,7 @@ describe Ci::Pipeline, models: true do
context 'on failure and build retry' do
before do
build.drop
- project.team << [user, :developer]
+ project.add_developer(user)
Ci::Build.retry(build, user)
end
@@ -776,7 +776,7 @@ describe Ci::Pipeline, models: true do
let(:latest_status) { pipeline.statuses.latest.pluck(:status) }
before do
- project.team << [user, :developer]
+ project.add_developer(user)
end
context 'when there is a failed build and failed external status' do
diff --git a/spec/services/ci/process_pipeline_service_spec.rb b/spec/services/ci/process_pipeline_service_spec.rb
index 823808ccce1..ef2ddc4b1d7 100644
--- a/spec/services/ci/process_pipeline_service_spec.rb
+++ b/spec/services/ci/process_pipeline_service_spec.rb
@@ -9,7 +9,7 @@ describe Ci::ProcessPipelineService, :services do
end
before do
- project.team << [user, :developer]
+ project.add_developer(user)
end
describe '#execute' do
diff --git a/spec/services/ci/retry_build_service_spec.rb b/spec/services/ci/retry_build_service_spec.rb
index 97c28ea50e0..b7e0308f033 100644
--- a/spec/services/ci/retry_build_service_spec.rb
+++ b/spec/services/ci/retry_build_service_spec.rb
@@ -15,7 +15,7 @@ describe Ci::RetryBuildService, :services do
context 'when user has ability to execute build' do
before do
- project.team << [user, :developer]
+ project.add_developer(user)
end
it 'creates a new build that represents the old one' do
@@ -59,7 +59,7 @@ describe Ci::RetryBuildService, :services do
context 'when user has ability to execute build' do
before do
- project.team << [user, :developer]
+ project.add_developer(user)
end
it 'creates a new build that represents the old one' do
diff --git a/spec/services/create_deployment_service_spec.rb b/spec/services/create_deployment_service_spec.rb
index 50679408dca..6fb4d517115 100644
--- a/spec/services/create_deployment_service_spec.rb
+++ b/spec/services/create_deployment_service_spec.rb
@@ -235,7 +235,7 @@ describe CreateDeploymentService, services: true do
context 'when build is retried' do
it_behaves_like 'does create environment and deployment' do
before do
- project.team << [user, :developer]
+ project.add_developer(user)
end
let(:deployable) { Ci::Build.retry(build, user) }
--
GitLab