From 422236c71eb8f1c88e83331b6eb74211fd7ccf49 Mon Sep 17 00:00:00 2001
From: Robert Speicher <rspeicher@gmail.com>
Date: Sat, 13 Jun 2015 18:24:51 -0400
Subject: [PATCH] Change `foo.should` syntax to `expect(foo).to` in specs
---
spec/controllers/autocomplete_controller_spec.rb | 16 ++++++++--------
spec/features/notes_on_merge_requests_spec.rb | 2 +-
spec/lib/gitlab/ldap/access_spec.rb | 4 ++--
spec/lib/gitlab/o_auth/auth_hash_spec.rb | 14 +++++++-------
spec/models/external_wiki_service_spec.rb | 2 +-
.../project_services/irker_service_spec.rb | 8 ++++----
spec/requests/api/issues_spec.rb | 8 ++++----
spec/requests/api/merge_requests_spec.rb | 6 +++---
spec/requests/api/milestones_spec.rb | 6 +++---
spec/requests/api/projects_spec.rb | 6 +++---
spec/services/destroy_group_service_spec.rb | 8 ++++----
spec/services/projects/destroy_service_spec.rb | 8 ++++----
spec/services/projects/transfer_service_spec.rb | 6 ++----
13 files changed, 46 insertions(+), 48 deletions(-)
diff --git a/spec/controllers/autocomplete_controller_spec.rb b/spec/controllers/autocomplete_controller_spec.rb
index a0909cec3bd..1ea1227b28b 100644
--- a/spec/controllers/autocomplete_controller_spec.rb
+++ b/spec/controllers/autocomplete_controller_spec.rb
@@ -15,9 +15,9 @@ describe AutocompleteController do
let(:body) { JSON.parse(response.body) }
- it { body.should be_kind_of(Array) }
- it { body.size.should eq(1) }
- it { body.first["username"].should == user.username }
+ it { expect(body).to be_kind_of(Array) }
+ it { expect(body.size).to eq(1) }
+ it { expect(body.first["username"]).to eq user.username }
end
context 'group members' do
@@ -32,9 +32,9 @@ describe AutocompleteController do
let(:body) { JSON.parse(response.body) }
- it { body.should be_kind_of(Array) }
- it { body.size.should eq(1) }
- it { body.first["username"].should == user.username }
+ it { expect(body).to be_kind_of(Array) }
+ it { expect(body.size).to eq(1) }
+ it { expect(body.first["username"]).to eq user.username }
end
context 'all users' do
@@ -45,7 +45,7 @@ describe AutocompleteController do
let(:body) { JSON.parse(response.body) }
- it { body.should be_kind_of(Array) }
- it { body.size.should eq(User.count) }
+ it { expect(body).to be_kind_of(Array) }
+ it { expect(body.size).to eq(User.count) }
end
end
diff --git a/spec/features/notes_on_merge_requests_spec.rb b/spec/features/notes_on_merge_requests_spec.rb
index c47368b1fda..b69b59d4158 100644
--- a/spec/features/notes_on_merge_requests_spec.rb
+++ b/spec/features/notes_on_merge_requests_spec.rb
@@ -90,7 +90,7 @@ describe 'Comments' do
#within(".current-note-edit-form") do
#fill_in "note[note]", with: "Some new content"
#find(".btn-cancel").click
- #find(".js-note-text", visible: false).text.should == note.note
+ #expect(find(".js-note-text", visible: false).text).to eq note.note
#end
#end
diff --git a/spec/lib/gitlab/ldap/access_spec.rb b/spec/lib/gitlab/ldap/access_spec.rb
index fc346ea29d0..038ac7e0d75 100644
--- a/spec/lib/gitlab/ldap/access_spec.rb
+++ b/spec/lib/gitlab/ldap/access_spec.rb
@@ -23,7 +23,7 @@ describe Gitlab::LDAP::Access do
it "should block user in GitLab" do
access.allowed?
- user.should be_blocked
+ expect(user).to be_blocked
end
end
@@ -44,7 +44,7 @@ describe Gitlab::LDAP::Access do
it "does not unblock user in GitLab" do
access.allowed?
- user.should be_blocked
+ expect(user).to be_blocked
end
end
diff --git a/spec/lib/gitlab/o_auth/auth_hash_spec.rb b/spec/lib/gitlab/o_auth/auth_hash_spec.rb
index 678086ffa14..165cde4f160 100644
--- a/spec/lib/gitlab/o_auth/auth_hash_spec.rb
+++ b/spec/lib/gitlab/o_auth/auth_hash_spec.rb
@@ -80,31 +80,31 @@ describe Gitlab::OAuth::AuthHash do
context 'auth_hash constructed with ASCII-8BIT encoding' do
it 'forces utf8 encoding on uid' do
- auth_hash.uid.encoding.should eql Encoding::UTF_8
+ expect(auth_hash.uid.encoding).to eql Encoding::UTF_8
end
it 'forces utf8 encoding on provider' do
- auth_hash.provider.encoding.should eql Encoding::UTF_8
+ expect(auth_hash.provider.encoding).to eql Encoding::UTF_8
end
it 'forces utf8 encoding on name' do
- auth_hash.name.encoding.should eql Encoding::UTF_8
+ expect(auth_hash.name.encoding).to eql Encoding::UTF_8
end
it 'forces utf8 encoding on full_name' do
- auth_hash.full_name.encoding.should eql Encoding::UTF_8
+ expect(auth_hash.full_name.encoding).to eql Encoding::UTF_8
end
it 'forces utf8 encoding on username' do
- auth_hash.username.encoding.should eql Encoding::UTF_8
+ expect(auth_hash.username.encoding).to eql Encoding::UTF_8
end
it 'forces utf8 encoding on email' do
- auth_hash.email.encoding.should eql Encoding::UTF_8
+ expect(auth_hash.email.encoding).to eql Encoding::UTF_8
end
it 'forces utf8 encoding on password' do
- auth_hash.password.encoding.should eql Encoding::UTF_8
+ expect(auth_hash.password.encoding).to eql Encoding::UTF_8
end
end
end
diff --git a/spec/models/external_wiki_service_spec.rb b/spec/models/external_wiki_service_spec.rb
index f2e77fc88c4..4bd5b0be61c 100644
--- a/spec/models/external_wiki_service_spec.rb
+++ b/spec/models/external_wiki_service_spec.rb
@@ -52,7 +52,7 @@ describe ExternalWikiService do
it 'should replace the wiki url' do
wiki_path = get_project_wiki_path(project)
- wiki_path.should match('https://gitlab.com')
+ expect(wiki_path).to match('https://gitlab.com')
end
end
end
diff --git a/spec/models/project_services/irker_service_spec.rb b/spec/models/project_services/irker_service_spec.rb
index 96ab95c05c9..4c437aab12b 100644
--- a/spec/models/project_services/irker_service_spec.rb
+++ b/spec/models/project_services/irker_service_spec.rb
@@ -51,7 +51,7 @@ describe IrkerService do
let(:_recipients) { 'a b c' }
it 'should not add an error if there is 3 recipients' do
subject.send :check_recipients_count
- subject.errors.should be_blank
+ expect(subject.errors).to be_blank
end
end
end
@@ -96,11 +96,11 @@ describe IrkerService do
conn = @irker_server.accept
conn.readlines.each do |line|
msg = JSON.load(line.chomp("\n"))
- msg.keys.should match_array(['to', 'privmsg'])
+ expect(msg.keys).to match_array(['to', 'privmsg'])
if msg['to'].is_a?(String)
- msg['to'].should == 'irc://chat.freenode.net/#commits'
+ expect(msg['to']).to eq 'irc://chat.freenode.net/#commits'
else
- msg['to'].should match_array(['irc://chat.freenode.net/#commits'])
+ expect(msg['to']).to match_array(['irc://chat.freenode.net/#commits'])
end
end
conn.close
diff --git a/spec/requests/api/issues_spec.rb b/spec/requests/api/issues_spec.rb
index 8770786f49a..5e65ad18c0e 100644
--- a/spec/requests/api/issues_spec.rb
+++ b/spec/requests/api/issues_spec.rb
@@ -196,10 +196,10 @@ describe API::API, api: true do
it 'should return a project issue by iid' do
get api("/projects/#{project.id}/issues?iid=#{issue.iid}", user)
- response.status.should == 200
- json_response.first['title'].should == issue.title
- json_response.first['id'].should == issue.id
- json_response.first['iid'].should == issue.iid
+ expect(response.status).to eq 200
+ expect(json_response.first['title']).to eq issue.title
+ expect(json_response.first['id']).to eq issue.id
+ expect(json_response.first['iid']).to eq issue.iid
end
it "should return 404 if issue id not found" do
diff --git a/spec/requests/api/merge_requests_spec.rb b/spec/requests/api/merge_requests_spec.rb
index 0ed5883914b..38c67bc9971 100644
--- a/spec/requests/api/merge_requests_spec.rb
+++ b/spec/requests/api/merge_requests_spec.rb
@@ -118,9 +118,9 @@ describe API::API, api: true do
it 'should return merge_request by iid' do
url = "/projects/#{project.id}/merge_requests?iid=#{merge_request.iid}"
get api(url, user)
- response.status.should == 200
- json_response.first['title'].should == merge_request.title
- json_response.first['id'].should == merge_request.id
+ expect(response.status).to eq 200
+ expect(json_response.first['title']).to eq merge_request.title
+ expect(json_response.first['id']).to eq merge_request.id
end
it "should return a 404 error if merge_request_id not found" do
diff --git a/spec/requests/api/milestones_spec.rb b/spec/requests/api/milestones_spec.rb
index 6890dd1f3a7..db0f6e3c0f5 100644
--- a/spec/requests/api/milestones_spec.rb
+++ b/spec/requests/api/milestones_spec.rb
@@ -32,9 +32,9 @@ describe API::API, api: true do
it 'should return a project milestone by iid' do
get api("/projects/#{project.id}/milestones?iid=#{milestone.iid}", user)
- response.status.should == 200
- json_response.first['title'].should == milestone.title
- json_response.first['id'].should == milestone.id
+ expect(response.status).to eq 200
+ expect(json_response.first['title']).to eq milestone.title
+ expect(json_response.first['id']).to eq milestone.id
end
it 'should return 401 error if user not authenticated' do
diff --git a/spec/requests/api/projects_spec.rb b/spec/requests/api/projects_spec.rb
index dbfd72e5f19..8fb1509c8b2 100644
--- a/spec/requests/api/projects_spec.rb
+++ b/spec/requests/api/projects_spec.rb
@@ -60,9 +60,9 @@ describe API::API, api: true do
it 'should include the project labels as the tag_list' do
get api('/projects', user)
- response.status.should == 200
- json_response.should be_an Array
- json_response.first.keys.should include('tag_list')
+ expect(response.status).to eq 200
+ expect(json_response).to be_an Array
+ expect(json_response.first.keys).to include('tag_list')
end
context 'and using search' do
diff --git a/spec/services/destroy_group_service_spec.rb b/spec/services/destroy_group_service_spec.rb
index 2a7372b986e..e28564b3866 100644
--- a/spec/services/destroy_group_service_spec.rb
+++ b/spec/services/destroy_group_service_spec.rb
@@ -23,8 +23,8 @@ describe DestroyGroupService do
Sidekiq::Testing.inline! { destroy_group(group, user) }
end
- it { gitlab_shell.exists?(group.path).should be_falsey }
- it { gitlab_shell.exists?(remove_path).should be_falsey }
+ it { expect(gitlab_shell.exists?(group.path)).to be_falsey }
+ it { expect(gitlab_shell.exists?(remove_path)).to be_falsey }
end
context 'Sidekiq fake' do
@@ -33,8 +33,8 @@ describe DestroyGroupService do
Sidekiq::Testing.fake! { destroy_group(group, user) }
end
- it { gitlab_shell.exists?(group.path).should be_falsey }
- it { gitlab_shell.exists?(remove_path).should be_truthy }
+ it { expect(gitlab_shell.exists?(group.path)).to be_falsey }
+ it { expect(gitlab_shell.exists?(remove_path)).to be_truthy }
end
end
diff --git a/spec/services/projects/destroy_service_spec.rb b/spec/services/projects/destroy_service_spec.rb
index 381008def5f..e83eef0b1a2 100644
--- a/spec/services/projects/destroy_service_spec.rb
+++ b/spec/services/projects/destroy_service_spec.rb
@@ -13,8 +13,8 @@ describe Projects::DestroyService do
end
it { expect(Project.all).not_to include(project) }
- it { Dir.exists?(path).should be_falsey }
- it { Dir.exists?(remove_path).should be_falsey }
+ it { expect(Dir.exists?(path)).to be_falsey }
+ it { expect(Dir.exists?(remove_path)).to be_falsey }
end
context 'Sidekiq fake' do
@@ -24,8 +24,8 @@ describe Projects::DestroyService do
end
it { expect(Project.all).not_to include(project) }
- it { Dir.exists?(path).should be_falsey }
- it { Dir.exists?(remove_path).should be_truthy }
+ it { expect(Dir.exists?(path)).to be_falsey }
+ it { expect(Dir.exists?(remove_path)).to be_truthy }
end
def destroy_project(project, user, params)
diff --git a/spec/services/projects/transfer_service_spec.rb b/spec/services/projects/transfer_service_spec.rb
index 5650626fb18..79acba78bda 100644
--- a/spec/services/projects/transfer_service_spec.rb
+++ b/spec/services/projects/transfer_service_spec.rb
@@ -20,8 +20,7 @@ describe Projects::TransferService do
@result = transfer_project(project, user, new_namespace_id: nil)
end
- it { expect(@result).not_to be_nil } # { result.should be_false } passes on nil
- it { expect(@result).to be_falsey }
+ it { expect(@result).to eq false }
it { expect(project.namespace).to eq(user.namespace) }
end
@@ -30,8 +29,7 @@ describe Projects::TransferService do
@result = transfer_project(project, user, new_namespace_id: group.id)
end
- it { expect(@result).not_to be_nil } # { result.should be_false } passes on nil
- it { expect(@result).to be_falsey }
+ it { expect(@result).to eq false }
it { expect(project.namespace).to eq(user.namespace) }
end
--
GitLab