diff --git a/app/models/board.rb b/app/models/board.rb index d6358fb15e8f636ef8c32c29ed0bc246eb7de97b..3240c4bede3f5b5cab9d61ebcc3c5a31e855a143 100644 --- a/app/models/board.rb +++ b/app/models/board.rb @@ -1,7 +1,7 @@ class Board < ActiveRecord::Base belongs_to :project - has_many :lists, -> { order(:list_type, :position) }, dependent: :destroy + has_many :lists, -> { order(:list_type, :position) }, dependent: :delete_all validates :project, presence: true end diff --git a/app/models/list.rb b/app/models/list.rb index b4fdab7893ab92004b58c6468e1f531109707b70..f2a59d18c46c682893e3cc3450bd2889a4e6d5e8 100644 --- a/app/models/list.rb +++ b/app/models/list.rb @@ -10,7 +10,15 @@ class List < ActiveRecord::Base delegate :name, to: :label, allow_nil: true, prefix: true + before_destroy :can_be_destroyed, unless: :label? + def title label? ? label_name : list_type.humanize end + + private + + def can_be_destroyed + false + end end diff --git a/spec/models/board_spec.rb b/spec/models/board_spec.rb index 23a91619a276153cb0d7408c7bd520777596d373..12d29540137c41dbf643f2a3b24562a61c0afce9 100644 --- a/spec/models/board_spec.rb +++ b/spec/models/board_spec.rb @@ -3,7 +3,7 @@ require 'rails_helper' describe Board do describe 'relationships' do it { is_expected.to belong_to(:project) } - it { is_expected.to have_many(:lists).order(list_type: :asc, position: :asc).dependent(:destroy) } + it { is_expected.to have_many(:lists).order(list_type: :asc, position: :asc).dependent(:delete_all) } end describe 'validations' do diff --git a/spec/models/list_spec.rb b/spec/models/list_spec.rb index 689011454d30148620b470d0831f4c9731248993..45c07a679cbc367a99b5802db2b5adb1c8f4ceb2 100644 --- a/spec/models/list_spec.rb +++ b/spec/models/list_spec.rb @@ -31,6 +31,27 @@ describe List do it { is_expected.not_to validate_presence_of(:position) } end end + + describe '#destroy' do + it 'can be destroyed when when list_type is set to label' do + subject = create(:label_list) + + expect(subject.destroy).to be_truthy + end + + it 'can not be destroyed when list_type is set to backlog' do + subject = create(:backlog_list) + + expect(subject.destroy).to be_falsey + end + + it 'can not be destroyed when when list_type is set to done' do + subject = create(:done_list) + + expect(subject.destroy).to be_falsey + end + end + describe '#title' do it 'returns label name when list_type is set to label' do subject.list_type = :label