diff --git a/app/controllers/projects/group_links_controller.rb b/app/controllers/projects/group_links_controller.rb index cd0f081cd7dce0f5bf140394ad2084bd6fd08048..606552fa85322b5486c8aa930fdf34c459125c3c 100644 --- a/app/controllers/projects/group_links_controller.rb +++ b/app/controllers/projects/group_links_controller.rb @@ -8,14 +8,11 @@ class Projects::GroupLinksController < Projects::ApplicationController def create group = Group.find(params[:link_group_id]) + return render_404 unless can?(current_user, :read_group, group) - if can?(current_user, :read_group, group) - project.project_group_links.create( - group: group, group_access: params[:link_group_access] - ) - else - return render_404 - end + project.project_group_links.create( + group: group, group_access: params[:link_group_access] + ) redirect_to namespace_project_group_links_path(project.namespace, project) end