From 66b6d82a3e2f3ea32cdd534f8bcbba8ed515ce2d Mon Sep 17 00:00:00 2001
From: Grzegorz Bizon <grzesiek.bizon@gmail.com>
Date: Mon, 18 Apr 2016 12:00:47 +0200
Subject: [PATCH] Use guard clause to check ability to share project
---
app/controllers/projects/group_links_controller.rb | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/app/controllers/projects/group_links_controller.rb b/app/controllers/projects/group_links_controller.rb
index cd0f081cd7d..606552fa853 100644
--- a/app/controllers/projects/group_links_controller.rb
+++ b/app/controllers/projects/group_links_controller.rb
@@ -8,14 +8,11 @@ class Projects::GroupLinksController < Projects::ApplicationController
def create
group = Group.find(params[:link_group_id])
+ return render_404 unless can?(current_user, :read_group, group)
- if can?(current_user, :read_group, group)
- project.project_group_links.create(
- group: group, group_access: params[:link_group_access]
- )
- else
- return render_404
- end
+ project.project_group_links.create(
+ group: group, group_access: params[:link_group_access]
+ )
redirect_to namespace_project_group_links_path(project.namespace, project)
end
--
GitLab