diff --git a/app/models/ci/build.rb b/app/models/ci/build.rb index 7c9899334ad8c0944c38df42d66060f270ced29d..5dbf66173de79101b39dee6034ec14db0ac88d68 100644 --- a/app/models/ci/build.rb +++ b/app/models/ci/build.rb @@ -67,7 +67,7 @@ module Ci environment: build.environment, status_event: 'enqueue' ) - MergeRequests::AddTodoWhenBuildFailsService.new(build.project, nil).close(new_build.pipeline) + MergeRequests::AddTodoWhenBuildFailsService.new(build.project, nil).close(new_build) build.pipeline.mark_as_processable_after_stage(build.stage_idx) new_build end diff --git a/app/models/ci/pipeline.rb b/app/models/ci/pipeline.rb index da0b9d83e1d5a51c6f2a4bc72665765fb34bc8f9..4c38a54ea3a59d878c521bb9712eea4d72aeb9d2 100644 --- a/app/models/ci/pipeline.rb +++ b/app/models/ci/pipeline.rb @@ -73,14 +73,6 @@ module Ci after_transition do |pipeline, transition| pipeline.execute_hooks unless transition.loopback? end - - after_transition [:created, :pending, :running] => :success do |pipeline| - MergeRequests::MergeWhenBuildSucceedsService.new(pipeline.project, nil).trigger(pipeline) - end - - after_transition any => :failed do |pipeline| - MergeRequests::AddTodoWhenBuildFailsService.new(pipeline.project, nil).execute(pipeline) - end end # ref can't be HEAD or SHA, can only be branch/tag name diff --git a/app/models/commit_status.rb b/app/models/commit_status.rb index 3d5e449f4037d4da3c8f160e4be216d6eb812168..b0718e2213c3840ab6320fdcdb8fb1698befceec 100644 --- a/app/models/commit_status.rb +++ b/app/models/commit_status.rb @@ -69,11 +69,6 @@ class CommitStatus < ActiveRecord::Base commit_status.update_attributes finished_at: Time.now end - after_transition any => [:success, :failed, :canceled] do |commit_status| - commit_status.pipeline.try(:process!) - true - end - after_transition [:created, :pending, :running] => :success do |commit_status| MergeRequests::MergeWhenBuildSucceedsService.new(commit_status.pipeline.project, nil).trigger(commit_status) end @@ -86,7 +81,7 @@ class CommitStatus < ActiveRecord::Base if commit_status.pipeline && !transition.loopback? ProcessPipelineWorker.perform_async( commit_status.pipeline.id, - process: HasStatus.COMPLETED_STATUSES.include?(commit_status.status)) + process: HasStatus::COMPLETED_STATUSES.include?(commit_status.status)) end true diff --git a/app/services/merge_requests/add_todo_when_build_fails_service.rb b/app/services/merge_requests/add_todo_when_build_fails_service.rb index 45c737898861e6e8b464231cca68bcf261c1c2fe..566049525cb724ee4682780f7d9f5791071d0c00 100644 --- a/app/services/merge_requests/add_todo_when_build_fails_service.rb +++ b/app/services/merge_requests/add_todo_when_build_fails_service.rb @@ -1,15 +1,15 @@ module MergeRequests class AddTodoWhenBuildFailsService < MergeRequests::BaseService # Adds a todo to the parent merge_request when a CI build fails - def execute(pipeline) - each_merge_request(pipeline) do |merge_request| + def execute(commit_status) + each_merge_request(commit_status) do |merge_request| todo_service.merge_request_build_failed(merge_request) end end # Closes any pending build failed todos for the parent MRs when a build is retried - def close(pipeline) - each_merge_request(pipeline) do |merge_request| + def close(commit_status) + each_merge_request(commit_status) do |merge_request| todo_service.merge_request_build_retried(merge_request) end end diff --git a/app/services/merge_requests/base_service.rb b/app/services/merge_requests/base_service.rb index 95b4f0ff7331e4446989c8cf045488c90a5ee9ae..d0d155b7ee1e8dd4b0752c8c5a4fe8099f9d3fcd 100644 --- a/app/services/merge_requests/base_service.rb +++ b/app/services/merge_requests/base_service.rb @@ -42,11 +42,11 @@ module MergeRequests super(:merge_request) end - def merge_request_from(pipeline) - branches = pipeline.ref + def merge_request_from(commit_status) + branches = commit_status.ref # This is for ref-less builds - branches ||= @project.repository.branch_names_contains(pipeline.sha) + branches ||= @project.repository.branch_names_contains(commit_status.sha) return [] if branches.blank? @@ -56,11 +56,14 @@ module MergeRequests merge_requests.uniq.select(&:source_project) end - def each_merge_request(pipeline) + def each_merge_request(commit_status) merge_request_from(commit_status).each do |merge_request| - next unless pipeline == merge_request.pipeline + pipeline = merge_request.pipeline - yield merge_request + next unless pipeline + next unless pipeline.sha == commit_status.sha + + yield merge_request, pipeline end end end diff --git a/app/workers/process_pipeline_worker.rb b/app/workers/process_pipeline_worker.rb index fb59a1efb7a251cd83b1ac1c415b6f0eceb8d814..fa1251b8e9fa250fff402d9bcf074ae5ccf6d953 100644 --- a/app/workers/process_pipeline_worker.rb +++ b/app/workers/process_pipeline_worker.rb @@ -10,7 +10,7 @@ class ProcessPipelineWorker return end - pipeline.process! if params[:process] + pipeline.process! if params['process'] pipeline.update_status end