diff --git a/app/models/repository.rb b/app/models/repository.rb index 116e808f3bbab3d457d8654c540cd0e78276fc7c..6c1cd308a4191fd8b663ee21ca591607eaf82751 100644 --- a/app/models/repository.rb +++ b/app/models/repository.rb @@ -628,18 +628,21 @@ class Repository target_sha = find_branch(target_branch).try(:target) # First make revert in temp branch - status = target_sha ? true : revert_commit(user, commit, target_branch, base_branch) + rm_branch(target_branch) if target_sha + success = revert_commit(user, commit, target_branch, base_branch) # Make the revert happen in the target branch - source_sha = find_branch(target_branch).target - target_sha = find_branch(base_branch).target - has_changes = is_there_something_to_merge?(source_sha, target_sha) + if success && !create_mr + source_sha = find_branch(target_branch).target + target_sha = find_branch(base_branch).target + has_changes = is_there_something_to_merge?(source_sha, target_sha) - if has_changes && !create_mr - status = revert_commit(user, commit, base_branch, base_branch) + if has_changes + success = revert_commit(user, commit, base_branch, base_branch) + end end - has_changes && status + has_changes && success end def revert_commit(user, commit, target_branch, base_branch) diff --git a/app/services/commits/revert_service.rb b/app/services/commits/revert_service.rb index 730e2017e8d295624febb94fa0becdbc5ccaa46a..5ac2853019bd50c9865aaa61ae002a1d4e7339df 100644 --- a/app/services/commits/revert_service.rb +++ b/app/services/commits/revert_service.rb @@ -14,7 +14,9 @@ module Commits if commit success else - error("Something went wrong. Your changes were not committed") + error("Sorry, we cannot revert this commit automatically. + It may have already been reverted, or a more recent commit may + have updated some of its content.") end rescue Repository::CommitError, Gitlab::Git::Repository::InvalidBlobName, GitHooksService::PreReceiveError, ValidationError => ex error(ex.message) @@ -26,7 +28,7 @@ module Commits # Create branch with revert commit reverted = repository.revert(current_user, @commit, @target_branch, @create_merge_request) - unless @create_merge_request + if reverted && !@create_merge_request repository.rm_branch(current_user, @commit.revert_branch_name) end