diff --git a/app/models/project_team.rb b/app/models/project_team.rb index e8606c8c2c64e71ad129c8fa79c6314366d35ef7..04f4fa849c40e713c0d2f5ea8e28a9c6b573da9b 100644 --- a/app/models/project_team.rb +++ b/app/models/project_team.rb @@ -248,9 +248,9 @@ class ProjectTeam # group access is developers we need to provide # both group master, developers as devs if int_level == group_link.group_access - im.where("access_level >= ?)", group_link.group_access) + im = im.where("access_level >= ?", group_link.group_access) else - im.send(level) + im = im.send(level) end end diff --git a/spec/models/project_team_spec.rb b/spec/models/project_team_spec.rb index 469e306044b4bea114414fce90bf2317e3c455b9..f979d66c88ca072cead62191c2c6463c25592ae6 100644 --- a/spec/models/project_team_spec.rb +++ b/spec/models/project_team_spec.rb @@ -111,6 +111,7 @@ describe ProjectTeam, models: true do group_access: Gitlab::Access::REPORTER ) + expect(project.team.guests).to be_empty expect(project.team.reporters).to contain_exactly(group_member.user) end end