From 91c07d16cd371a545a9ad089ccc0313c7a13bb5b Mon Sep 17 00:00:00 2001
From: Yorick Peterse <yorickpeterse@gmail.com>
Date: Fri, 13 May 2016 12:51:52 +0200
Subject: [PATCH] Fixed Rubocop deprecation warnings
---
app/services/projects/update_pages_service.rb | 2 +-
spec/services/projects/update_pages_service_spec.rb | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/app/services/projects/update_pages_service.rb b/app/services/projects/update_pages_service.rb
index f588f6feb8c..90fff91dd9c 100644
--- a/app/services/projects/update_pages_service.rb
+++ b/app/services/projects/update_pages_service.rb
@@ -25,7 +25,7 @@ module Projects
# Check if we did extract public directory
archive_public_path = File.join(archive_path, 'public')
- raise 'pages miss the public folder' unless Dir.exists?(archive_public_path)
+ raise 'pages miss the public folder' unless Dir.exist?(archive_public_path)
raise 'pages are outdated' unless latest?
deploy_page!(archive_public_path)
diff --git a/spec/services/projects/update_pages_service_spec.rb b/spec/services/projects/update_pages_service_spec.rb
index af1c6a5e7b5..411b22a0fb8 100644
--- a/spec/services/projects/update_pages_service_spec.rb
+++ b/spec/services/projects/update_pages_service_spec.rb
@@ -5,7 +5,7 @@ describe Projects::UpdatePagesService do
let(:pipeline) { create :ci_pipeline, project: project, sha: project.commit('HEAD').sha }
let(:build) { create :ci_build, pipeline: pipeline, ref: 'HEAD' }
let(:invalid_file) { fixture_file_upload(Rails.root + 'spec/fixtures/dk.png') }
-
+
subject { described_class.new(project, build) }
before do
@@ -18,7 +18,7 @@ describe Projects::UpdatePagesService do
let(:empty_file) { fixture_file_upload(Rails.root + "spec/fixtures/pages_empty.#{format}") }
let(:metadata) do
filename = Rails.root + "spec/fixtures/pages.#{format}.meta"
- fixture_file_upload(filename) if File.exists?(filename)
+ fixture_file_upload(filename) if File.exist?(filename)
end
before do
@@ -73,7 +73,7 @@ describe Projects::UpdatePagesService do
build.update_attributes(artifacts_file: invalid_file)
expect(execute).not_to eq(:success)
end
-
+
def execute
subject.execute[:status]
end
--
GitLab