From 9374b7eb0b28527123abad40a070ee4a5b1f0d9f Mon Sep 17 00:00:00 2001
From: Lin Jen-Shin <godfat@godfat.org>
Date: Wed, 23 Mar 2016 20:05:31 +0800
Subject: [PATCH] Avoid using the same name between methods and variables
---
lib/gitlab/email/receiver.rb | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/lib/gitlab/email/receiver.rb b/lib/gitlab/email/receiver.rb
index 2ca21af5bc8..d4b6f6d120d 100644
--- a/lib/gitlab/email/receiver.rb
+++ b/lib/gitlab/email/receiver.rb
@@ -45,12 +45,12 @@ module Gitlab
note = create_note(reply)
unless note.persisted?
- message = "The comment could not be created for the following reasons:"
+ msg = "The comment could not be created for the following reasons:"
note.errors.full_messages.each do |error|
- message << "\n\n- #{error}"
+ msg << "\n\n- #{error}"
end
- raise InvalidNoteError, message
+ raise InvalidNoteError, msg
end
end
@@ -63,13 +63,13 @@ module Gitlab
end
def reply_key
- reply_key = nil
+ key = nil
message.to.each do |address|
- reply_key = Gitlab::IncomingEmail.key_from_address(address)
- break if reply_key
+ key = Gitlab::IncomingEmail.key_from_address(address)
+ break if key
end
- reply_key
+ key
end
def sent_notification
--
GitLab