diff --git a/lib/gitlab/ldap/access.rb b/lib/gitlab/ldap/access.rb index 71931b79f6200b4396ce85af53b1d13621cb26fe..4e48ff11871dadf2c2e226de3004d8150653ca29 100644 --- a/lib/gitlab/ldap/access.rb +++ b/lib/gitlab/ldap/access.rb @@ -15,7 +15,7 @@ module Gitlab def allowed?(user) if Gitlab::LDAP::Person.find_by_dn(user.extern_uid, adapter) - !Gitlab::LDAP::Person.ad_disabled?(user.extern_uid, adapter) + !Gitlab::LDAP::Person.active_directory_disabled?(user.extern_uid, adapter) else false end diff --git a/lib/gitlab/ldap/person.rb b/lib/gitlab/ldap/person.rb index 3a97944b1225fda0a8b80fa8dba3867046ea0dc7..9ad6618bd46448e8dc4613a1b904fb92859c2435 100644 --- a/lib/gitlab/ldap/person.rb +++ b/lib/gitlab/ldap/person.rb @@ -16,7 +16,7 @@ module Gitlab adapter.user('dn', dn) end - def self.ad_disabled?(dn, adapter=nil) + def self.active_directory_disabled?(dn, adapter=nil) adapter ||= Gitlab::LDAP::Adapter.new adapter.dn_matches_filter?(dn, AD_USER_DISABLED) end diff --git a/spec/lib/gitlab/ldap/ldap_access_spec.rb b/spec/lib/gitlab/ldap/ldap_access_spec.rb index e76cc4f2fde76d9fad5e974d5d9cfd778fccde7c..d8c107502ba49ceca3e29514253afc2b5249568f 100644 --- a/spec/lib/gitlab/ldap/ldap_access_spec.rb +++ b/spec/lib/gitlab/ldap/ldap_access_spec.rb @@ -17,13 +17,13 @@ describe Gitlab::LDAP::Access do before { Gitlab::LDAP::Person.stub(find_by_dn: :ldap_user) } context 'and the Active Directory disabled flag is set' do - before { Gitlab::LDAP::Person.stub(ad_disabled?: true) } + before { Gitlab::LDAP::Person.stub(active_directory_disabled?: true) } it { should be_false } end context 'and the Active Directory disabled flag is not set' do - before { Gitlab::LDAP::Person.stub(ad_disabled?: false) } + before { Gitlab::LDAP::Person.stub(active_directory_disabled?: false) } it { should be_true } end