From c2bcfab18af1cf9253a47d4ffd3ea48e43cd19be Mon Sep 17 00:00:00 2001
From: Lin Jen-Shin <godfat@godfat.org>
Date: Tue, 6 Sep 2016 19:53:02 +0800
Subject: [PATCH] Remove redundant tests, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5525#note_14993999
---
.../slack_service/build_message_spec.rb | 12 ------------
.../slack_service/pipeline_message_spec.rb | 12 ------------
2 files changed, 24 deletions(-)
diff --git a/spec/models/project_services/slack_service/build_message_spec.rb b/spec/models/project_services/slack_service/build_message_spec.rb
index 0b876f4fd26..452f4e2782c 100644
--- a/spec/models/project_services/slack_service/build_message_spec.rb
+++ b/spec/models/project_services/slack_service/build_message_spec.rb
@@ -47,18 +47,6 @@ describe SlackService::BuildMessage do
end
end
- describe '#seconds_name' do
- let(:status) { 'failed' }
- let(:color) { 'danger' }
- let(:duration) { 1 }
-
- it 'returns seconds as singular when there is only one' do
- expect(subject.pretext).to be_empty
- expect(subject.fallback).to eq(message)
- expect(subject.attachments).to eq([text: message, color: color])
- end
- end
-
def build_message(status_text = status)
"<example.gitlab.com|project_name>:" \
" Commit <example.gitlab.com/commit/" \
diff --git a/spec/models/project_services/slack_service/pipeline_message_spec.rb b/spec/models/project_services/slack_service/pipeline_message_spec.rb
index 384b22b7103..babb3909f56 100644
--- a/spec/models/project_services/slack_service/pipeline_message_spec.rb
+++ b/spec/models/project_services/slack_service/pipeline_message_spec.rb
@@ -46,18 +46,6 @@ describe SlackService::PipelineMessage do
end
end
- describe '#seconds_name' do
- let(:status) { 'failed' }
- let(:color) { 'danger' }
- let(:duration) { 1 }
-
- it 'returns seconds as singular when there is only one' do
- expect(subject.pretext).to be_empty
- expect(subject.fallback).to eq(message)
- expect(subject.attachments).to eq([text: message, color: color])
- end
- end
-
def build_message(status_text = status)
"<example.gitlab.com|project_name>:" \
" Pipeline <example.gitlab.com/pipelines/123|97de212e>" \
--
GitLab