From f30e2a6ec7c011d0649aad9f118bf8c5a57ecdbc Mon Sep 17 00:00:00 2001
From: Lin Jen-Shin <godfat@godfat.org>
Date: Fri, 3 Feb 2017 17:29:08 +0800
Subject: [PATCH] Use message_id_regexp variable for the regexp
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8620#note_22021001
---
lib/gitlab/incoming_email.rb | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/gitlab/incoming_email.rb b/lib/gitlab/incoming_email.rb
index a386d9b36fb..0ea42148c58 100644
--- a/lib/gitlab/incoming_email.rb
+++ b/lib/gitlab/incoming_email.rb
@@ -35,7 +35,9 @@ module Gitlab
end
def key_from_fallback_message_id(mail_id)
- mail_id[/\Areply\-(.+)@#{Gitlab.config.gitlab.host}\z/, 1]
+ message_id_regexp = /\Areply\-(.+)@#{Gitlab.config.gitlab.host}\z/
+
+ mail_id[message_id_regexp, 1]
end
def scan_fallback_references(references)
--
GitLab