diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 78fceb74881778e408c50930050e351b97b8d839..2d94861058f6fd355e85e70ed2c7a706baf9bee2 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,21 +1,20 @@
# This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2017-02-21 18:00:50 -0600 using RuboCop version 0.46.0.
+# `rubocop --auto-gen-config --exclude-limit 0`
+# on 2017-02-22 10:58:40 -0600 using RuboCop version 0.46.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
+# Offense count: 1
+# Cop supports --auto-correct.
+Performance/RedundantBlockCall:
+ Enabled: false
+
# Offense count: 15
# Configuration parameters: CustomIncludeMethods.
RSpec/EmptyExampleGroup:
- Exclude:
- - 'spec/features/issues_spec.rb'
- - 'spec/features/notes_on_merge_requests_spec.rb'
- - 'spec/lib/gitlab/git_access_spec.rb'
- - 'spec/models/project_snippet_spec.rb'
- - 'spec/models/protected_branch_spec.rb'
- - 'spec/routing/routing_spec.rb'
+ Enabled: false
# Offense count: 63
# Configuration parameters: EnforcedStyle, SupportedStyles.
@@ -27,27 +26,28 @@ RSpec/HookArgument:
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: is_expected, should
RSpec/ImplicitExpect:
- Exclude:
- - 'spec/lib/banzai/renderer_spec.rb'
- - 'spec/models/project_group_link_spec.rb'
- - 'spec/models/project_services/external_wiki_service_spec.rb'
- - 'spec/models/project_spec.rb'
+ Enabled: false
# Offense count: 1
RSpec/SingleArgumentMessageChain:
- Exclude:
- - 'spec/requests/api/internal_spec.rb'
+ Enabled: false
+
+# Offense count: 8
+# Cop supports --auto-correct.
+Style/AlignArray:
+ Enabled: false
+
+# Offense count: 11
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle, SupportedLastArgumentHashStyles.
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Style/AlignHash:
+ Enabled: false
# Offense count: 6
# Cop supports --auto-correct.
Style/EachWithObject:
- Exclude:
- - 'app/services/merge_requests/get_urls_service.rb'
- - 'lib/ci/ansi2html.rb'
- - 'lib/expand_variables.rb'
- - 'lib/gitlab/ee_compat_check.rb'
- - 'lib/gitlab/import_export/members_mapper.rb'
- - 'lib/gitlab/import_export/relation_factory.rb'
+ Enabled: false
# Offense count: 24
# Cop supports --auto-correct.
@@ -59,11 +59,7 @@ Style/EmptyElse:
# Offense count: 4
# Cop supports --auto-correct.
Style/EmptyLiteral:
- Exclude:
- - 'features/steps/project/commits/commits.rb'
- - 'lib/gitlab/fogbugz_import/importer.rb'
- - 'lib/gitlab/git/diff_collection.rb'
- - 'spec/lib/gitlab/workhorse_spec.rb'
+ Enabled: false
# Offense count: 55
# Cop supports --auto-correct.
@@ -82,35 +78,18 @@ Style/ExtraSpacing:
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: format, sprintf, percent
Style/FormatString:
- Exclude:
- - 'app/models/ci/pipeline.rb'
- - 'app/services/gravatar_service.rb'
- - 'config/initializers/rack_lineprof.rb'
- - 'lib/gitlab/version_info.rb'
- - 'spec/factories/lfs_objects.rb'
- - 'spec/services/issues/move_service_spec.rb'
-
-# Offense count: 261
+ Enabled: false
+
+# Offense count: 263
# Configuration parameters: MinBodyLength.
Style/GuardClause:
Enabled: false
# Offense count: 12
Style/IfInsideElse:
- Exclude:
- - 'app/controllers/projects/forks_controller.rb'
- - 'app/controllers/projects/imports_controller.rb'
- - 'app/helpers/milestones_helper.rb'
- - 'app/helpers/projects_helper.rb'
- - 'app/services/system_note_service.rb'
- - 'config/initializers/1_settings.rb'
- - 'lib/gitlab/auth.rb'
- - 'lib/gitlab/checks/change_access.rb'
- - 'lib/gitlab/database.rb'
- - 'spec/controllers/projects/merge_requests_controller_spec.rb'
- - 'spec/support/import_export/export_file_helper.rb'
-
-# Offense count: 178
+ Enabled: false
+
+# Offense count: 177
# Cop supports --auto-correct.
# Configuration parameters: MaxLineLength.
Style/IfUnlessModifier:
@@ -123,7 +102,7 @@ Style/IfUnlessModifier:
Style/IndentArray:
Enabled: false
-# Offense count: 110
+# Offense count: 108
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_braces
@@ -140,98 +119,40 @@ Style/Lambda:
# Offense count: 7
# Cop supports --auto-correct.
Style/LineEndConcatenation:
- Exclude:
- - 'app/helpers/tree_helper.rb'
- - 'app/models/merge_request.rb'
- - 'app/services/git_operation_service.rb'
- - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
- - 'spec/lib/gitlab/incoming_email_spec.rb'
+ Enabled: false
# Offense count: 22
# Cop supports --auto-correct.
Style/MethodCallParentheses:
- Exclude:
- - 'lib/ci/ansi2html.rb'
- - 'spec/controllers/projects/issues_controller_spec.rb'
- - 'spec/controllers/projects/merge_requests_controller_spec.rb'
- - 'spec/controllers/projects/snippets_controller_spec.rb'
- - 'spec/features/dashboard/datetime_on_tooltips_spec.rb'
- - 'spec/features/issues/filtered_search/dropdown_assignee_spec.rb'
- - 'spec/features/issues/filtered_search/dropdown_author_spec.rb'
- - 'spec/features/issues/filtered_search/dropdown_milestone_spec.rb'
- - 'spec/features/issues/filtered_search/filter_issues_spec.rb'
- - 'spec/helpers/submodule_helper_spec.rb'
- - 'spec/lib/gitlab/git/repository_spec.rb'
- - 'spec/requests/api/internal_spec.rb'
+ Enabled: false
# Offense count: 9
Style/MethodMissing:
- Exclude:
- - 'app/controllers/projects/application_controller.rb'
- - 'app/models/commit.rb'
- - 'app/models/network/commit.rb'
- - 'app/models/repository.rb'
- - 'config/initializers/gollum.rb'
- - 'lib/bitbucket/collection.rb'
- - 'lib/gitlab/github_import/client.rb'
- - 'lib/gitlab/lazy.rb'
- - 'lib/uploaded_file.rb'
+ Enabled: false
# Offense count: 3
# Cop supports --auto-correct.
Style/MultilineIfModifier:
- Exclude:
- - 'app/helpers/snippets_helper.rb'
- - 'app/models/project_wiki.rb'
- - 'lib/gitlab/workhorse.rb'
+ Enabled: false
# Offense count: 8
# Cop supports --auto-correct.
Style/NestedParenthesizedCalls:
- Exclude:
- - 'app/helpers/commits_helper.rb'
- - 'app/workers/irker_worker.rb'
- - 'spec/lib/gitlab/ci/build/artifacts/metadata/entry_spec.rb'
- - 'spec/lib/gitlab/email/message/repository_push_spec.rb'
+ Enabled: false
# Offense count: 15
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
# SupportedStyles: skip_modifier_ifs, always
Style/Next:
- Exclude:
- - 'app/models/namespace.rb'
- - 'app/models/user.rb'
- - 'app/services/merge_requests/refresh_service.rb'
- - 'config/initializers/secret_token.rb'
- - 'db/migrate/20161220141214_remove_dot_git_from_group_names.rb'
- - 'db/migrate/20161226122833_remove_dot_git_from_usernames.rb'
- - 'lib/banzai/filter/math_filter.rb'
- - 'lib/banzai/filter/table_of_contents_filter.rb'
- - 'lib/gitlab/fogbugz_import/importer.rb'
- - 'lib/gitlab/metrics/instrumentation.rb'
- - 'lib/gitlab/metrics/sampler.rb'
- - 'lib/gitlab/project_search_results.rb'
+ Enabled: false
# Offense count: 19
# Cop supports --auto-correct.
# Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix:
- Exclude:
- - 'config/initializers/1_settings.rb'
- - 'config/initializers/secret_token.rb'
- - 'lib/gitlab/import_export/command_line_util.rb'
- - 'lib/gitlab/shell.rb'
- - 'lib/gitlab/workhorse.rb'
- - 'spec/features/projects/import_export/export_file_spec.rb'
- - 'spec/lib/gitlab/git/blob_spec.rb'
- - 'spec/lib/gitlab/git/hook_spec.rb'
- - 'spec/lib/gitlab/git/repository_spec.rb'
- - 'spec/lib/gitlab/workhorse_spec.rb'
- - 'spec/support/import_export/export_file_helper.rb'
- - 'spec/support/test_env.rb'
- - 'spec/tasks/gitlab/backup_rake_spec.rb'
+ Enabled: false
# Offense count: 68
# Cop supports --auto-correct.
@@ -245,39 +166,16 @@ Style/NumericPredicate:
Style/ParallelAssignment:
Enabled: false
-# Offense count: 459
+# Offense count: 463
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
Enabled: false
-# Offense count: 10
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: lower_case_q, upper_case_q
-Style/PercentQLiterals:
- Exclude:
- - 'spec/lib/gitlab/diff/highlight_spec.rb'
- - 'spec/models/project_services/bamboo_service_spec.rb'
- - 'spec/models/project_services/buildkite_service_spec.rb'
- - 'spec/models/project_services/drone_ci_service_spec.rb'
- - 'spec/models/project_services/teamcity_service_spec.rb'
- - 'spec/workers/repository_import_worker_spec.rb'
-
# Offense count: 13
# Cop supports --auto-correct.
Style/PerlBackrefs:
- Exclude:
- - 'app/controllers/projects/application_controller.rb'
- - 'app/helpers/submodule_helper.rb'
- - 'lib/banzai/filter/abstract_reference_filter.rb'
- - 'lib/banzai/filter/autolink_filter.rb'
- - 'lib/banzai/filter/emoji_filter.rb'
- - 'lib/banzai/filter/gollum_tags_filter.rb'
- - 'lib/expand_variables.rb'
- - 'lib/gitlab/diff/highlight.rb'
- - 'lib/gitlab/search_results.rb'
- - 'lib/gitlab/sherlock/query.rb'
+ Enabled: false
# Offense count: 72
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
@@ -297,13 +195,7 @@ Style/PreferredHashMethods:
# Offense count: 8
# Cop supports --auto-correct.
Style/Proc:
- Exclude:
- - 'app/mailers/base_mailer.rb'
- - 'app/models/milestone.rb'
- - 'app/models/service.rb'
- - 'lib/api/api_guard.rb'
- - 'lib/gitlab/ldap/config.rb'
- - 'spec/initializers/trusted_proxies_spec.rb'
+ Enabled: false
# Offense count: 62
# Cop supports --auto-correct.
@@ -315,44 +207,18 @@ Style/RaiseArgs:
# Offense count: 3
# Cop supports --auto-correct.
Style/RedundantBegin:
- Exclude:
- - 'app/models/merge_request.rb'
- - 'app/services/projects/import_service.rb'
- - 'lib/gitlab/git/commit.rb'
+ Enabled: false
# Offense count: 32
# Cop supports --auto-correct.
Style/RedundantFreeze:
- Exclude:
- - 'app/models/commit.rb'
- - 'app/models/merge_request.rb'
- - 'app/validators/color_validator.rb'
- - 'app/validators/line_code_validator.rb'
- - 'lib/api/templates.rb'
- - 'lib/api/v3/templates.rb'
- - 'lib/banzai/filter/blockquote_fence_filter.rb'
- - 'lib/banzai/filter/gollum_tags_filter.rb'
- - 'lib/banzai/filter/yaml_front_matter_filter.rb'
- - 'lib/gitlab/diff/inline_diff.rb'
- - 'lib/gitlab/ee_compat_check.rb'
- - 'lib/gitlab/import_export/relation_factory.rb'
- - 'lib/gitlab/middleware/static.rb'
- - 'lib/gitlab/regex.rb'
+ Enabled: false
# Offense count: 15
# Cop supports --auto-correct.
# Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn:
- Exclude:
- - 'app/controllers/application_controller.rb'
- - 'app/controllers/concerns/issuable_actions.rb'
- - 'app/controllers/groups/application_controller.rb'
- - 'app/controllers/groups_controller.rb'
- - 'app/controllers/omniauth_callbacks_controller.rb'
- - 'app/controllers/profiles/keys_controller.rb'
- - 'app/controllers/projects/labels_controller.rb'
- - 'app/controllers/projects/milestones_controller.rb'
- - 'app/services/access_token_validation_service.rb'
+ Enabled: false
# Offense count: 365
# Cop supports --auto-correct.
@@ -374,29 +240,21 @@ Style/RescueModifier:
# Offense count: 7
# Cop supports --auto-correct.
Style/SelfAssignment:
- Exclude:
- - 'app/models/project_team.rb'
- - 'app/services/notification_service.rb'
- - 'lib/api/runners.rb'
- - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
- - 'spec/support/import_export/configuration_helper.rb'
+ Enabled: false
# Offense count: 2
# Configuration parameters: Methods.
# Methods: {"reduce"=>["acc", "elem"]}, {"inject"=>["acc", "elem"]}
Style/SingleLineBlockParams:
- Exclude:
- - 'app/models/commit.rb'
- - 'spec/support/services_shared_context.rb'
+ Enabled: false
# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: AllowIfMethodIsEmpty.
Style/SingleLineMethods:
- Exclude:
- - 'lib/ci/ansi2html.rb'
+ Enabled: false
-# Offense count: 150
+# Offense count: 153
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: space, no_space
@@ -407,36 +265,16 @@ Style/SpaceBeforeBlockBraces:
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment.
Style/SpaceBeforeFirstArg:
- Exclude:
- - 'config/routes/project.rb'
- - 'features/steps/project/source/browse_files.rb'
- - 'features/steps/project/source/markdown_render.rb'
- - 'spec/routing/project_routing_spec.rb'
- - 'spec/services/system_note_service_spec.rb'
+ Enabled: false
# Offense count: 38
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: require_no_space, require_space
Style/SpaceInLambdaLiteral:
- Exclude:
- - 'app/models/commit_status.rb'
- - 'app/models/concerns/mentionable.rb'
- - 'app/models/issue.rb'
- - 'app/models/member.rb'
- - 'lib/api/entities.rb'
- - 'lib/file_size_validator.rb'
- - 'lib/gitlab/visibility_level.rb'
- - 'spec/models/concerns/participable_spec.rb'
- - 'spec/models/cycle_analytics/code_spec.rb'
- - 'spec/models/cycle_analytics/issue_spec.rb'
- - 'spec/models/cycle_analytics/plan_spec.rb'
- - 'spec/models/cycle_analytics/production_spec.rb'
- - 'spec/models/cycle_analytics/review_spec.rb'
- - 'spec/models/cycle_analytics/staging_spec.rb'
- - 'spec/models/cycle_analytics/test_spec.rb'
-
-# Offense count: 205
+ Enabled: false
+
+# Offense count: 201
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
# SupportedStyles: space, no_space
@@ -451,8 +289,7 @@ Style/SpaceInsideParens:
# Offense count: 4
# Cop supports --auto-correct.
Style/SpaceInsidePercentLiteralDelimiters:
- Exclude:
- - 'lib/gitlab/git_access.rb'
+ Enabled: false
# Offense count: 52
# Cop supports --auto-correct.
@@ -466,21 +303,7 @@ Style/SpecialGlobalVars:
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation:
- Exclude:
- - 'app/helpers/labels_helper.rb'
- - 'app/helpers/time_helper.rb'
- - 'app/helpers/todos_helper.rb'
- - 'app/models/application_setting.rb'
- - 'app/models/project_services/campfire_service.rb'
- - 'app/models/project_services/jira_service.rb'
- - 'db/migrate/20161017125927_add_unique_index_to_labels.rb'
- - 'features/steps/groups.rb'
- - 'features/steps/project/merge_requests.rb'
- - 'lib/banzai/filter/abstract_reference_filter.rb'
- - 'lib/ci/gitlab_ci_yaml_processor.rb'
- - 'lib/gitlab/google_code_import/importer.rb'
- - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
- - 'spec/models/project_services/hipchat_service_spec.rb'
+ Enabled: false
# Offense count: 57
# Cop supports --auto-correct.
@@ -494,12 +317,7 @@ Style/SymbolProc:
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowSafeAssignment.
# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
Style/TernaryParentheses:
- Exclude:
- - 'features/support/capybara.rb'
- - 'lib/api/v3/projects.rb'
- - 'lib/banzai/filter/table_of_contents_filter.rb'
- - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
- - 'spec/support/capybara.rb'
+ Enabled: false
# Offense count: 43
# Cop supports --auto-correct.
@@ -512,15 +330,9 @@ Style/TrailingCommaInArguments:
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
- Exclude:
- - 'app/controllers/admin/background_jobs_controller.rb'
- - 'app/controllers/invites_controller.rb'
- - 'app/controllers/projects/git_http_client_controller.rb'
- - 'app/helpers/tab_helper.rb'
- - 'lib/gitlab/git/repository.rb'
- - 'lib/gitlab/logger.rb'
+ Enabled: false
-# Offense count: 76
+# Offense count: 69
# Cop supports --auto-correct.
Style/TrailingWhitespace:
Enabled: false
@@ -530,46 +342,19 @@ Style/TrailingWhitespace:
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors:
- Exclude:
- - 'app/models/external_issue.rb'
- - 'app/serializers/base_serializer.rb'
- - 'lib/gitlab/ldap/person.rb'
+ Enabled: false
# Offense count: 2
# Cop supports --auto-correct.
Style/UnlessElse:
- Exclude:
- - 'lib/gitlab/project_search_results.rb'
- - 'spec/features/issues/award_emoji_spec.rb'
+ Enabled: false
# Offense count: 19
# Cop supports --auto-correct.
Style/UnneededInterpolation:
- Exclude:
- - 'app/helpers/boards_helper.rb'
- - 'app/helpers/projects_helper.rb'
- - 'app/helpers/search_helper.rb'
- - 'app/helpers/time_helper.rb'
- - 'app/models/merge_request.rb'
- - 'app/models/project_services/pushover_service.rb'
- - 'features/steps/project/forked_merge_requests.rb'
- - 'spec/controllers/admin/services_controller_spec.rb'
- - 'spec/features/admin/admin_projects_spec.rb'
- - 'spec/features/issues_spec.rb'
- - 'spec/features/projects/branches_spec.rb'
- - 'spec/features/projects/issuable_templates_spec.rb'
- - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
- - 'spec/requests/api/issues_spec.rb'
- - 'spec/views/projects/commit/_commit_box.html.haml_spec.rb'
+ Enabled: false
# Offense count: 8
# Cop supports --auto-correct.
Style/ZeroLengthPredicate:
- Exclude:
- - 'app/models/deploy_key.rb'
- - 'app/models/merge_request.rb'
- - 'app/models/network/commit.rb'
- - 'app/models/network/graph.rb'
- - 'app/models/project_services/asana_service.rb'
- - 'app/models/repository.rb'
- - 'lib/extracts_path.rb'
+ Enabled: false