Skip to content
Snippets Groups Projects
Commit d729d1fb authored by Kevin Hill's avatar Kevin Hill
Browse files

[ci skip] Even further simplifying API

parent 758970bb
No related branches found
No related tags found
No related merge requests found
Source diff could not be displayed: it is too large. Options to address this: view the blob.
Loading
Loading
@@ -16,6 +16,7 @@ import Dashboard from './Dashboard';
import defaultOptions from './Options';
import {addEvent, noop} from './Utils';
import {InvalidCallback, RenderableNotFound} from './Errors'
import Renderable from './Renderable';
 
/**
* @property {string} VERSION
Loading
Loading
@@ -102,7 +103,6 @@ export default class LavaJs extends EventEmitter {
* as an independent library.
*
* @public
* @static
* @param {object} json
* @return {Renderable}
*/
Loading
Loading
@@ -123,6 +123,10 @@ export default class LavaJs extends EventEmitter {
* @param {Renderable} renderable
*/
store(renderable) {
if (renderable instanceof Renderable === false) {
renderable = this.create(renderable);
}
console.log(`[lava.js] Storing ${renderable.uuid}`);
 
this._addPackages(renderable.packages);
Loading
Loading
@@ -164,16 +168,6 @@ export default class LavaJs extends EventEmitter {
callback(renderable);
}
 
/**
* Convenience method for creating and storing a new Chart / Dashboard.
*
* @public
* @param json
*/
createAndStore(json) {
return this.store(this.create(json));
}
/**
* Runs the Lava.js module
*
Loading
Loading
Loading
Loading
@@ -73,7 +73,7 @@ abstract class Renderable implements Arrayable, Customizable, Javascriptable, Js
public function toJavascript()
{
return sprintf(
'window.lava.createAndStore(%s);',
'lava.store(%s);',
$this->toJson()
);
}
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment