Moderator notice of held messages not sent to list owners
I just ran into this. It's recent. The cause appears to be https://gitlab.com/mailman/mailman/commit/c50b3ee558eabd00624b0efc7ad9324535df1709. The issue is chains/hold.py creates the notice as an instance of message.UserNotification
with recipients = mlist.owner_address
and calls the send
method with to_moderators=True
. The problem is message.UserNotification().send()
with to_moderators=True
replaces the recipients with the moderators rather than adding the moderators to recipients.
I think mail to mlist.owner_address
already includes the moderators, so I think just dropping to_moderators=True
will fix this notice. Code should be reviewed for other places that need this too.