Mailman Core merge requestshttps://staging.gitlab.com/mailman/mailman/-/merge_requests2017-10-09T04:03:25Zhttps://staging.gitlab.com/mailman/mailman/-/merge_requests/252Authentication & ARC signing2017-10-09T04:03:25Zusername-removed-1156362Authentication & ARC signingThis merge request includes both authentication(DKIM/DMARC) and ARC signing handlers added to the pipeline. The ARC signing functionality is done via an official release of dkimpy, which formally validates against the ARC test suite.
...This merge request includes both authentication(DKIM/DMARC) and ARC signing handlers added to the pipeline. The ARC signing functionality is done via an official release of dkimpy, which formally validates against the ARC test suite.
One thing which may need some discussion is the way in which DNS timeouts are handled. I created a bit of logic in the outgoing runner that aborts a message and re-queues it into the pipeline if necessary. However in order not to re-process the message, I had to keep around an unprocessed version of the message. I'm not sure if this is the best approach.3.2username-removed-169689stephen@xemacs.orgusername-removed-169689stephen@xemacs.orghttps://staging.gitlab.com/mailman/mailman/-/merge_requests/204Add ARC support to Mailman.2017-05-22T18:56:26Zusername-removed-391087Add ARC support to Mailman.Add handlers for ARC, which can be enabled by the user through the configuration settings.
The handlers if enabled, are added to the BasePipeline. Specifically, the two handlers - `authentication_results` & `sign_message`, are added.
Th...Add handlers for ARC, which can be enabled by the user through the configuration settings.
The handlers if enabled, are added to the BasePipeline. Specifically, the two handlers - `authentication_results` & `sign_message`, are added.
The `authentication_results` handler is responsible for generating the preliminary Authentication Results before the message is altered by any other handlers. And the `sign_message` handler does the actual signing of the message, i.e. affixing the ARC-Authentication-Results, ARC-Message-Signature, ARC-Seal to the message before it goes out for delivery to the outgoing runner.
A few tests have been added to check the proper functioning of the pipelines with the new handlers. Since some of the tests require the presence of a local key for signing purposes, a test key has been created and stored in a new directory `test_data` inside the tests directory.
Currently the code for the two new dependencies - `arc` and `dkim` (refactored version) is not available on PyPI. As a workaround, os.system explicit calls have been added temporarily to the setup script to install these dependencies from their repository code.
@warsaw @stephenjturnbull3.2username-removed-169689stephen@xemacs.orgusername-removed-169689stephen@xemacs.orghttps://staging.gitlab.com/mailman/mailman/-/merge_requests/70Cover some subject prefix use cases.2016-11-25T16:58:27Zusername-removed-35210Cover some subject prefix use cases.The `subject_prefix` handler has many bugs and was mostly not covered for lists with a non-ascii charset.
This MR fixes most of the cases, but if you ask me this module needs some refactoring. For example, all tests still pass when on...The `subject_prefix` handler has many bugs and was mostly not covered for lists with a non-ascii charset.
This MR fixes most of the cases, but if you ask me this module needs some refactoring. For example, all tests still pass when only the `mixed_charsets` function is used.
We can use this MR to fix the current bugs or go with the refactoring (I have it ready).3.2