Mailman Core merge requestshttps://staging.gitlab.com/mailman/mailman/-/merge_requests2017-08-30T19:39:52Zhttps://staging.gitlab.com/mailman/mailman/-/merge_requests/299WIP: Pluggable workflows2017-08-30T19:39:52Zusername-removed-1178112WIP: Pluggable workflowsThis MR will refactor the current Subscription and Unsubscription workflows into pluggable components. Which will allow to easily insert additional steps into the [un]subscription process for both core and plugins.
This also means split...This MR will refactor the current Subscription and Unsubscription workflows into pluggable components. Which will allow to easily insert additional steps into the [un]subscription process for both core and plugins.
This also means splitting the current [Unn]SubscriptionWorkflow classes into multiple blocks that can be chained, somewhat like chains work. So that they can be reused by other workflows.
Let's say a subscription workflow, introduced by a plugin, that checks the address for being present in some company/organization/other database so that only customers/members/... are allowed to subscribe to a list with that policy.3.2https://staging.gitlab.com/mailman/mailman/-/merge_requests/277Improve rest test coverage on the 3.1 version of the rest API2017-05-26T07:16:11Zusername-removed-1345525britt@brittg.comImprove rest test coverage on the 3.1 version of the rest APIThis PR contains the work needed to test both the 3.0 and 3.1 versions of the rest api.
~~This is currently a WIP as I am fixing up some of the bugs I've found out of this work however I would appreciate any feedback on the approach i...This PR contains the work needed to test both the 3.0 and 3.1 versions of the rest api.
~~This is currently a WIP as I am fixing up some of the bugs I've found out of this work however I would appreciate any feedback on the approach i'm taking to accomplish this.~~
Edit: Ready for review.
Closes: #333 3.2https://staging.gitlab.com/mailman/mailman/-/merge_requests/276WIP: implement per-list roster visibility options2017-05-25T00:02:17Zusername-removed-1351084WIP: implement per-list roster visibility optionsSee issue #108
- Add roster_visibility to MailingList.See issue #108
- Add roster_visibility to MailingList.3.2https://staging.gitlab.com/mailman/mailman/-/merge_requests/252Authentication & ARC signing2017-10-09T04:03:25Zusername-removed-1156362Authentication & ARC signingThis merge request includes both authentication(DKIM/DMARC) and ARC signing handlers added to the pipeline. The ARC signing functionality is done via an official release of dkimpy, which formally validates against the ARC test suite.
...This merge request includes both authentication(DKIM/DMARC) and ARC signing handlers added to the pipeline. The ARC signing functionality is done via an official release of dkimpy, which formally validates against the ARC test suite.
One thing which may need some discussion is the way in which DNS timeouts are handled. I created a bit of logic in the outgoing runner that aborts a message and re-queues it into the pipeline if necessary. However in order not to re-process the message, I had to keep around an unprocessed version of the message. I'm not sure if this is the best approach.3.2username-removed-169689stephen@xemacs.orgusername-removed-169689stephen@xemacs.orghttps://staging.gitlab.com/mailman/mailman/-/merge_requests/211Remove mime_is_default_digest legacy attribute.2017-06-16T12:45:38Zusername-removed-671608Remove mime_is_default_digest legacy attribute.Fixes: https://gitlab.com/mailman/mailman/issues/235Fixes: https://gitlab.com/mailman/mailman/issues/2353.2https://staging.gitlab.com/mailman/mailman/-/merge_requests/204Add ARC support to Mailman.2017-05-22T18:56:26Zusername-removed-391087Add ARC support to Mailman.Add handlers for ARC, which can be enabled by the user through the configuration settings.
The handlers if enabled, are added to the BasePipeline. Specifically, the two handlers - `authentication_results` & `sign_message`, are added.
Th...Add handlers for ARC, which can be enabled by the user through the configuration settings.
The handlers if enabled, are added to the BasePipeline. Specifically, the two handlers - `authentication_results` & `sign_message`, are added.
The `authentication_results` handler is responsible for generating the preliminary Authentication Results before the message is altered by any other handlers. And the `sign_message` handler does the actual signing of the message, i.e. affixing the ARC-Authentication-Results, ARC-Message-Signature, ARC-Seal to the message before it goes out for delivery to the outgoing runner.
A few tests have been added to check the proper functioning of the pipelines with the new handlers. Since some of the tests require the presence of a local key for signing purposes, a test key has been created and stored in a new directory `test_data` inside the tests directory.
Currently the code for the two new dependencies - `arc` and `dkim` (refactored version) is not available on PyPI. As a workaround, os.system explicit calls have been added temporarily to the setup script to install these dependencies from their repository code.
@warsaw @stephenjturnbull3.2username-removed-169689stephen@xemacs.orgusername-removed-169689stephen@xemacs.orghttps://staging.gitlab.com/mailman/mailman/-/merge_requests/202Implement alias_domain attribute for domain object.2017-10-08T07:11:10Zusername-removed-107958Implement alias_domain attribute for domain object.This branch implements and tests an alias_domain attribute for Domain objects. See the section `Unusual Postfix configuration` at src/mailman/docs/MTA.rst for more about the purpose of this attribute.
I think this branch is almost compl...This branch implements and tests an alias_domain attribute for Domain objects. See the section `Unusual Postfix configuration` at src/mailman/docs/MTA.rst for more about the purpose of this attribute.
I think this branch is almost complete as far as the core is concerned with the sole exception that it adds a column for `alias_domain` to the `domain` database table, and I'm sure this requires some migration, but I haven't done that as I don't really know how.
Also, `mailman_client` and `postorius` will also need updates to be able to display and set the alias_domain. I haven't looked at that at all yet.3.2https://staging.gitlab.com/mailman/mailman/-/merge_requests/193Issue 158: Add ability to log to syslog instead of to file2016-11-14T14:04:22Zusername-removed-637286Issue 158: Add ability to log to syslog instead of to fileAdded new config options for supporting dynamic 'address' and 'facility' (they default to the SysLogHandler defaults).
File or SysLog logging is configurable per log.Added new config options for supporting dynamic 'address' and 'facility' (they default to the SysLogHandler defaults).
File or SysLog logging is configurable per log.3.2https://staging.gitlab.com/mailman/mailman/-/merge_requests/192Added rest call to get all emails of a user subscribed to a list2017-06-16T12:45:38Zusername-removed-671608Added rest call to get all emails of a user subscribed to a listFixes: https://gitlab.com/mailman/mailman/issues/232Fixes: https://gitlab.com/mailman/mailman/issues/2323.2https://staging.gitlab.com/mailman/mailman/-/merge_requests/168Database and Superuser command update2017-05-22T19:02:25Zusername-removed-563829Database and Superuser command updatecloses: mailman/postorius#138
Database and super user command updated from previous merge closes: mailman/postorius#138
Database and super user command updated from previous merge 3.2username-removed-169689stephen@xemacs.orgusername-removed-169689stephen@xemacs.orghttps://staging.gitlab.com/mailman/mailman/-/merge_requests/144Add pot file2016-11-26T05:24:18Zusername-removed-208463Add pot fileI created the pot file by running
```
xgettext --language=Python --keyword=_ --output=po/mailman.pot --from-code=UTF-8 `find . -name "*.py"`
```
@warsaw do you want me to exclude anything? we could specify the files manually
I created the pot file by running
```
xgettext --language=Python --keyword=_ --output=po/mailman.pot --from-code=UTF-8 `find . -name "*.py"`
```
@warsaw do you want me to exclude anything? we could specify the files manually
3.2https://staging.gitlab.com/mailman/mailman/-/merge_requests/70Cover some subject prefix use cases.2016-11-25T16:58:27Zusername-removed-35210Cover some subject prefix use cases.The `subject_prefix` handler has many bugs and was mostly not covered for lists with a non-ascii charset.
This MR fixes most of the cases, but if you ask me this module needs some refactoring. For example, all tests still pass when on...The `subject_prefix` handler has many bugs and was mostly not covered for lists with a non-ascii charset.
This MR fixes most of the cases, but if you ask me this module needs some refactoring. For example, all tests still pass when only the `mixed_charsets` function is used.
We can use this MR to fix the current bugs or go with the refactoring (I have it ready).3.2https://staging.gitlab.com/mailman/mailman/-/merge_requests/64Add the List-ID header to administrivia messages2017-01-04T11:25:10Zusername-removed-35210Add the List-ID header to administrivia messagesRFC 2919 states about List-Id: "This header SHOULD be included on all messages distributed by the list (including command responses to individual users), and on other messages where the message clearly applies to this particular distinct...RFC 2919 states about List-Id: "This header SHOULD be included on all messages distributed by the list (including command responses to individual users), and on other messages where the message clearly applies to this particular distinct list."
It was not included in held message notifications before, I think it should be.
Fixes #1643.2https://staging.gitlab.com/mailman/mailman/-/merge_requests/61Discard incoming mail with invalid addresses2017-08-29T15:03:26Zusername-removed-35210Discard incoming mail with invalid addressesThis branch drops incoming email with an invalid sender address.This branch drops incoming email with an invalid sender address.3.2