Skip to content

Fix two problems and close #260

username-removed-56772 requested to merge issue260 into master
  1. The subscription workflow was not checking if the potential subscriber was already a member, so it would send a confirmation message to such subscribers. Replying to that would raise an exception since the user is already subscribed.

  2. Conversion of POST request parameters using bool was incorrect because the parameters come in as strings, not Python True/False objects. So bool("False") always returned True, meaning that such requests were always pre_verified, pre_confirmed, and pre_approved.

This doesn't totally jive with what we've seen in production, since some requests do still get confirmation messages.

Merge request reports