If the feature flag `ci_dag_limit_needs` is turned on for a GitLab
instance, a job can now depend on up to ten jobs instead of five

Allison Browne authored Dec 10, 2019 and Bob Van Landuyt :neckbeard: committed Dec 10, 2019

Add table to store the sentry event and issue ids
that are related to a gitlab issue

This MR extracts a lot of functinality
from ProjectTreeRestorer into RelationTreeRestorer
 in order to introduce a new GroupTreeRestorer
that is going to utilize this logic as well.

This MR Also changes a few other classes
to make them compatible with groups.

This commit persists and controls auto stop date for environments

Kerri Miller authored Dec 09, 2019 and Grzegorz Bizon committed Dec 09, 2019

.

Reuben Pereira authored Dec 09, 2019 and Thong Kuah committed Dec 09, 2019

Create new service to do template variable replacement on the query
parameter of the Prometheus proxy API.

Stubs for Gitaly calls are memoized by storage and service names in the
`@stubs` class variable. Normally this doesn't cause a problem, but an
example in `spec/lib/gitlab/gitaly_client/cleanup_service_spec.rb`
expected that a new stub would always be instantiated. Since
`spec/services/projects/cleanup_service_spec.rb` preceded
`spec/lib/gitlab/gitaly_client/cleanup_service_spec.rb`, the stub had
already been instantiated, causing the test to fail.

To fix this problem, we just clear out the Gitaly stubs for
`spec/lib/gitlab/gitaly_client/cleanup_service_spec.rb`.

Closes https://gitlab.com/gitlab-org/gitlab/issues/38535

Adds missing spec for fogbugz importer

Auto-correct some references in RSpec as:
- expect_any_instance_of -> expect_next_instance_of
- allow_any_instance_of -> allow_next_instance_of

Related to https://gitlab.com/gitlab-org/gitlab/issues/34997

* API::Helpers::Pagination#paginate only exposes offset pagination
* API::Helpers::Pagination#paginate_and_retrieve! supports both types

I wanted to make it explicit that keyset pagination returns an array
instead of a relation. This does not match the behavior of offset
pagination, hence not mixing those in #paginate.

This is in line with what we document:
https://docs.gitlab.com/ee/api/README.html#status-codes

This aligns with offset pagination, where we also allow up to 100
records max.

This is the squashed together change from
https://gitlab.com/gitlab-org/gitlab/merge_requests/19623
that had been reverted previously.

Based on the refactoring in
https://gitlab.com/gitlab-org/gitlab/merge_requests/21130

It works the same way as https://gitlab.com/gitlab-org/gitlab/merge_requests/14846:

It consists of two parts:

1. Redirecting users to the configured external storage
1. Allowing the external storage to request the static object(s)
   on behalf of the user by means of specific tokens

Related to https://gitlab.com/gitlab-com/gl-infra/scalability/issues/4

Matt Kasa authored Dec 06, 2019 and Thong Kuah committed Dec 06, 2019

Relates to https://gitlab.com/gitlab-org/gitlab/merge_requests/20244

Co-Authored-By: Thong Kuah <tkuah@gitlab.com>

It uses the existing cache for the
MergeRequestDiffBatch collection class.

Add a layer of CI configuration on top of the .gitlab-ci.yml
which uses `include:` feature to include a file from repository,
from a remote URL or from a template (Auto-DevOps)

The idea here is to make it explicit that at this point we are handling
an array and not a relation anymore.

This separates the "relation builder" from the "batch counting" concern.

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

- Refactor ActionRateLimiter
- Add rate limits to Project Export API

Updated release controller spec file.
Added new API entity spec file.

Michael Kozono authored Dec 04, 2019 and Mayra Cabrera committed Dec 04, 2019

If `gitlab_rails['rack_attack']['admin_area_protected_paths']` is true,
then the Admin Area settings take priority over the Omnibus-managed
protected path throttle settings.

Adds partial indices to keys within `ci_variables` and
`ci_pipeline_variables` tables to track configuration of Web Application
Firewall for running environments

This avoids leaking information into Rails.cache that could influence
other specs.

Reuse the `Support::GitAccessActor` to find an actor for the internal
API.

That way we're a bit closer to having a single way of accessing the
user.

We block IP addresses when failed Git auths reach a certain
threshold.

This block applied to all requests so for every request, we
had to check Redis to see if the IP is blocked. This caused
unnecessary Redis load.

This MR changes the block to only apply to Git requests as
it is described in the documentation

Also, add docs on how to use this template to install GitLab managed
apps (v2)

Alex Ives authored Nov 15, 2019 and Matt Kasa committed Dec 02, 2019

- Add RBAC permission to list deployments in knative-serving namespace
- Ensure service account has new permission
- Update documentation to instruct people to add the ability to list
  deployments in knative-serving
- Add get_cluster_role_bindings delegation to kubeclient
- Add KnativeVersionRoleBindingFinder
- Add knative_version_role_binding to KubernetesNamespace prereq
- Update tests for knative version role and binding

Relates to https://gitlab.com/gitlab-org/gitlabktl/issues/17

Co-Authored-By: Matt Kasa <mkasa@gitlab.com>