This reverts merge request !19541

Mark Lapierre authored Dec 02, 2019 and Walmyr Lima e Silva Filho committed Dec 02, 2019

One of the improvements available in this version is better handling
of unexpected alerts, which might help solve a problem we're facing

See https://gitlab.com/gitlab-org/gitlab/issues/34551
And https://github.com/teamcapybara/capybara/pull/2150

Also updates capybara-screenshot too because the previous version
wouldn't work with capybara 3.

Also changes the API client to log out after creating an access token
if it wasn't already logged in. This is so that it doesn't leave the
browser logged in at the start of tests when they expect to be able to
log in. For example, if a test is the first in the suite it will log
in to create an access token. If that happens in a before(:context)
block, the test will already be logged in, so an attempt to log in
would fail.

See https://gitlab.com/gitlab-org/gitlab/issues/34551

Mark Lapierre authored Oct 15, 2019 and Sanad Liaquat committed Oct 15, 2019

Previously fabricate_or_use would only create a User instance with the
provided username and password. This was fine when only those creds
were needed (e.g., to sign on), but it's not enough in tests that
need other user details, e.g., the user's name.

This changes fabricate_or_use so that it fetches the user via the API,
which provides access to the user's details.

They were recently changed, breaking the test. And they should be
tested in FE tests anyway.

Also change a block argument so a cop doesn't have to be disabled

Disable QA/AmbiguousPageObjectName cop for all offenses
under QA

See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28915

Wait for the new file modal to stop animating before clicking it

We now need to click the commit button 3 times:
1. To enter commit mode
2. To being staging changes
3. To submit the commit

The 'Create new' dropdown is no longer available on a blank project
so use the 'New file' button instead.

* Factory::Base -> Resource::Base, and therefore:
* Factory::Resource::Project -> Resource::Project

* Factory::Base -> Resource::Base, and therefore:
* Factory::Resource::Project -> Resource::Project

To avoid confusion with tags.

To avoid confusion with tags.

The Menu namespace was changed in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22115 and
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/7799.

Fixes https://gitlab.com/gitlab-org/quality/nightly/issues/22

.

Signed-off-by: Rémy Coutable <remy@rymai.me>

The Menu namespace was changed in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22115 and
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/7799.

Fixes https://gitlab.com/gitlab-org/quality/nightly/issues/22

.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Adds tests that adds new files via file templates via the Files view
and the Web IDE.

Includes changes to page objects and associated code

Fetches template content from the API rather than hardcoding strings
that will need to be updated if the templates change. Some of the
content is stored as flat files but we can't use them because they're
not included in the docker images gitlab-qa uses.