Add http status cop to all group controller specs

347 files inspected, 176 offenses detected, 176 offenses corrected

.rubocop.yml

@@ -343,6 +343,8 @@ RSpec/HaveGitlabHttpStatus:
     - 'ee/spec/controllers/*.rb'
     - 'spec/controllers/projects/**/*.rb'
     - 'ee/spec/controllers/projects/**/*.rb'
+    - 'spec/controllers/groups/**/*.rb'
+    - 'ee/spec/controllers/groups/**/*.rb'
     - 'spec/requests/*.rb'
     - 'ee/spec/requests/*.rb'

ee/spec/controllers/groups/audit_events_controller_spec.rb

@@ -32,7 +32,7 @@
           request
-          expect(response).to have_gitlab_http_status(200)
+          expect(response).to have_gitlab_http_status(:ok)
           expect(response).to render_template(:index)
         end
@@ -87,7 +87,7 @@
       it 'renders 404' do
         request
-        expect(response).to have_gitlab_http_status(404)
+        expect(response).to have_gitlab_http_status(:not_found)
       end
     end
   end

ee/spec/controllers/groups/autocomplete_sources_controller_spec.rb

@@ -17,7 +17,7 @@
     it 'returns 200 status' do
       get :epics, params: { group_id: group }
-      expect(response).to have_gitlab_http_status(200)
+      expect(response).to have_gitlab_http_status(:ok)
     end
     it 'returns the correct response' do
@@ -41,7 +41,7 @@
       get :milestones, params: { group_id: group }
-      expect(response).to have_gitlab_http_status(200)
+      expect(response).to have_gitlab_http_status(:ok)
       expect(json_response.count).to eq(1)
       expect(json_response.first).to include(
         'iid' => group_milestone.iid, 'title' => group_milestone.title
@@ -53,7 +53,7 @@
     it 'returns 200 status' do
       get :commands, params: { group_id: group, type: 'Epic', type_id: epic.iid }
-      expect(response).to have_gitlab_http_status(200)
+      expect(response).to have_gitlab_http_status(:ok)
     end
     it 'returns the correct response' do

ee/spec/controllers/groups/billings_controller_spec.rb

@@ -23,7 +23,7 @@
         get :index, params: { group_id: group }
-        expect(response).to have_gitlab_http_status(200)
+        expect(response).to have_gitlab_http_status(:ok)
         expect(response).to render_template(:index)
       end
@@ -44,7 +44,7 @@
         get :index, params: { group_id: group.id }
-        expect(response).to have_gitlab_http_status(404)
+        expect(response).to have_gitlab_http_status(:not_found)
       end
       it 'renders 404 when it is not gitlab.com' do
@@ -54,7 +54,7 @@
         get :index, params: { group_id: group }
-        expect(response).to have_gitlab_http_status(404)
+        expect(response).to have_gitlab_http_status(:not_found)
       end
     end
   end

ee/spec/controllers/groups/boards_controller_spec.rb

@@ -37,7 +37,7 @@
         it 'returns a not found 404 response' do
           list_boards format: :json
-          expect(response).to have_gitlab_http_status(404)
+          expect(response).to have_gitlab_http_status(:not_found)
           expect(response.content_type).to eq 'application/json'
         end
       end
@@ -68,7 +68,7 @@ def list_boards(format: :html)
         list_boards(recent: true)
-        expect(response).to have_gitlab_http_status(401)
+        expect(response).to have_gitlab_http_status(:unauthorized)
       end
     end
   end

ee/spec/controllers/groups/clusters_controller_spec.rb

@@ -42,7 +42,7 @@
         it 'renders not found' do
           get :prometheus_proxy, params: prometheus_proxy_params
-          expect(response).to have_gitlab_http_status(404)
+          expect(response).to have_gitlab_http_status(:not_found)
         end
         context 'with invalid clusterable id' do

ee/spec/controllers/groups/contribution_analytics_controller_spec.rb

@@ -45,7 +45,7 @@ def create_push_event(author, project)
     get :show, params: { group_id: group.path }
-    expect(response).to have_gitlab_http_status(404)
+    expect(response).to have_gitlab_http_status(:not_found)
   end
   context 'unlicensed but we show promotions' do
@@ -60,14 +60,14 @@ def create_push_event(author, project)
       get :show, params: { group_id: group.path }
-      expect(response).to have_gitlab_http_status(200)
+      expect(response).to have_gitlab_http_status(:ok)
     end
   end
   it 'sets instance variables properly', :aggregate_failures do
     get :show, params: { group_id: group.path }
-    expect(response).to have_gitlab_http_status(200)
+    expect(response).to have_gitlab_http_status(:ok)
     expect(assigns[:data_collector].users).to match_array([user, user2, user3])
     expect(assigns[:data_collector].total_events_by_author_count.values.sum).to eq(6)

ee/spec/controllers/groups/dependency_proxies_controller_spec.rb

@@ -20,7 +20,7 @@
       it 'returns 200 and renders the view' do
         get :show, params: { group_id: group.to_param }
-        expect(response).to have_gitlab_http_status(200)
+        expect(response).to have_gitlab_http_status(:ok)
         expect(response).to render_template('groups/dependency_proxies/show')
       end
     end
@@ -28,7 +28,7 @@
     it 'returns 404 when feature is disabled' do
       get :show, params: { group_id: group.to_param }
-      expect(response).to have_gitlab_http_status(404)
+      expect(response).to have_gitlab_http_status(:not_found)
     end
   end
@@ -41,14 +41,14 @@
       it 'redirects back to show page' do
         put :update, params: update_params
-        expect(response).to have_gitlab_http_status(302)
+        expect(response).to have_gitlab_http_status(:found)
       end
     end
     it 'returns 404 when feature is disabled' do
       put :update, params: update_params
-      expect(response).to have_gitlab_http_status(404)
+      expect(response).to have_gitlab_http_status(:not_found)
     end
     def update_params

ee/spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb

@@ -40,7 +40,7 @@
         it 'proxies status from the remote token request' do
           get_manifest
-          expect(response).to have_gitlab_http_status(503)
+          expect(response).to have_gitlab_http_status(:service_unavailable)
           expect(response.body).to eq('Service Unavailable')
         end
       end
@@ -57,7 +57,7 @@
         it 'proxies status from the remote manifest request' do
           get_manifest
-          expect(response).to have_gitlab_http_status(400)
+          expect(response).to have_gitlab_http_status(:bad_request)
           expect(response.body).to be_empty
         end
       end
@@ -65,7 +65,7 @@
       it 'returns 200 with manifest file' do
         get_manifest
-        expect(response).to have_gitlab_http_status(200)
+        expect(response).to have_gitlab_http_status(:ok)
         expect(response.body).to eq(manifest)
       end
     end
@@ -73,7 +73,7 @@
     it 'returns 404 when feature is disabled' do
       get_manifest
-      expect(response).to have_gitlab_http_status(404)
+      expect(response).to have_gitlab_http_status(:not_found)
     end
     def get_manifest
@@ -108,7 +108,7 @@ def get_manifest
         it 'proxies status from the remote blob request' do
           get_blob
-          expect(response).to have_gitlab_http_status(400)
+          expect(response).to have_gitlab_http_status(:bad_request)
           expect(response.body).to be_empty
         end
       end
@@ -130,7 +130,7 @@ def get_manifest
     it 'returns 404 when feature is disabled' do
       get_blob
-      expect(response).to have_gitlab_http_status(404)
+      expect(response).to have_gitlab_http_status(:not_found)
     end
     def get_blob

ee/spec/controllers/groups/epic_issues_controller_spec.rb

@@ -25,7 +25,7 @@
     end
     it 'returns 400 status' do
-      expect(response).to have_gitlab_http_status(404)
+      expect(response).to have_gitlab_http_status(:not_found)
     end
   end
@@ -59,7 +59,7 @@
           subject
-          expect(response).to have_gitlab_http_status(404)
+          expect(response).to have_gitlab_http_status(:not_found)
         end
       end
     end
@@ -84,7 +84,7 @@
           subject
           list_service_response = EpicIssues::ListService.new(epic, user).execute
-          expect(response).to have_gitlab_http_status(200)
+          expect(response).to have_gitlab_http_status(:ok)
           expect(json_response).to eq('message' => nil, 'issuables' => list_service_response.as_json)
         end
@@ -97,7 +97,7 @@
         it 'returns correct response for the correct issue reference' do
           subject
-          expect(response).to have_gitlab_http_status(403)
+          expect(response).to have_gitlab_http_status(:forbidden)
         end
         it 'does not create a new EpicIssue record' do

ee/spec/controllers/groups/epic_links_controller_spec.rb

@@ -22,7 +22,7 @@
     end
     it 'returns 400 status' do
-      expect(response).to have_gitlab_http_status(404)
+      expect(response).to have_gitlab_http_status(:not_found)
     end
   end
@@ -50,7 +50,7 @@
         it 'returns the correct JSON response' do
           list_service_response = EpicLinks::ListService.new(parent_epic, user).execute
-          expect(response).to have_gitlab_http_status(200)
+          expect(response).to have_gitlab_http_status(:ok)
           expect(json_response).to eq(list_service_response.as_json)
         end
       end
@@ -61,7 +61,7 @@
           subject
-          expect(response).to have_gitlab_http_status(404)
+          expect(response).to have_gitlab_http_status(:not_found)
         end
       end
     end
@@ -90,7 +90,7 @@
           subject
           list_service_response = EpicLinks::ListService.new(parent_epic, user).execute
-          expect(response).to have_gitlab_http_status(200)
+          expect(response).to have_gitlab_http_status(:ok)
           expect(json_response).to eq('message' => nil, 'issuables' => list_service_response.as_json)
         end
@@ -103,7 +103,7 @@
         it 'returns 403 status' do
           subject
-          expect(response).to have_gitlab_http_status(403)
+          expect(response).to have_gitlab_http_status(:forbidden)
         end
         it 'does not update parent attribute' do
@@ -140,7 +140,7 @@
         it 'returns status 200' do
           subject
-          expect(response).to have_gitlab_http_status(200)
+          expect(response).to have_gitlab_http_status(:ok)
         end
         it 'updates the epic position' do
@@ -153,7 +153,7 @@
           it 'returns status 404' do
             subject
-            expect(response).to have_gitlab_http_status(404)
+            expect(response).to have_gitlab_http_status(:not_found)
           end
         end
       end
@@ -162,7 +162,7 @@
         it 'returns status 403' do
           subject
-          expect(response).to have_gitlab_http_status(403)
+          expect(response).to have_gitlab_http_status(:forbidden)
         end
       end
     end

ee/spec/controllers/groups/epics/notes_controller_spec.rb

@@ -66,13 +66,13 @@
     it "returns status 302 for html" do
       post :create, params: request_params.merge(format: :html)
-      expect(response).to have_gitlab_http_status(302)
+      expect(response).to have_gitlab_http_status(:found)
     end
     it "returns status 200 for json" do
       post :create, params: request_params
-      expect(response).to have_gitlab_http_status(200)
+      expect(response).to have_gitlab_http_status(:ok)
       expect(parsed_response[:id]).not_to be_nil
     end
@@ -95,7 +95,7 @@
       it "creates reply note for discussion" do
         post :create, params: request_params
-        expect(response).to have_gitlab_http_status(200)
+        expect(response).to have_gitlab_http_status(:ok)
         expect(parsed_response[:errors]).to be_nil
       end
     end
@@ -143,7 +143,7 @@
       it "returns status 200" do
         delete :destroy, params: request_params
-        expect(response).to have_gitlab_http_status(200)
+        expect(response).to have_gitlab_http_status(:ok)
       end
       it "deletes the note" do
@@ -159,7 +159,7 @@
       it "returns status 404" do
         delete :destroy, params: request_params
-        expect(response).to have_gitlab_http_status(404)
+        expect(response).to have_gitlab_http_status(:not_found)
       end
     end
   end
@@ -183,7 +183,7 @@
         post(:toggle_award_emoji, params: request_params.merge(name: "thumbsup"))
       end.to change { note.award_emoji.count }.by(1)
-      expect(response).to have_gitlab_http_status(200)
+      expect(response).to have_gitlab_http_status(:ok)
     end
     it "removes the already awarded emoji" do
@@ -193,7 +193,7 @@
         post(:toggle_award_emoji, params: request_params.merge(name: "thumbsup"))
       end.to change { AwardEmoji.count }.by(-1)
-      expect(response).to have_gitlab_http_status(200)
+      expect(response).to have_gitlab_http_status(:ok)
     end
   end
 end

ee/spec/controllers/groups/epics_controller_spec.rb

@@ -17,7 +17,7 @@
       it 'returns 404 status' do
         subject
-        expect(response).to have_gitlab_http_status(404)
+        expect(response).to have_gitlab_http_status(:not_found)
       end
     end
@@ -56,7 +56,7 @@
       it "returns index" do
         get :index, params: { group_id: group }
-        expect(response).to have_gitlab_http_status(200)
+        expect(response).to have_gitlab_http_status(:ok)
       end
       context 'when there is no logged in user' do
@@ -67,7 +67,7 @@
           get :index, params: { group_id: group, sort: 'start_date_asc' }
           expect(cookies['epic_sort']).to eq('start_date_asc')
-          expect(response).to have_gitlab_http_status(200)
+          expect(response).to have_gitlab_http_status(:ok)
         end
       end
@@ -77,7 +77,7 @@
             get :index, params: { group_id: group, sort: 'start_date_asc' }
             expect(user.user_preference.epics_sort).to eq('start_date_asc')
-            expect(response).to have_gitlab_http_status(200)
+            expect(response).to have_gitlab_http_status(:ok)
           end
         end
@@ -88,7 +88,7 @@
             get :index, params: { group_id: group, sort: 'start_date_asc' }
             expect(user.reload.user_preference.epics_sort).to eq('start_date_asc')
-            expect(response).to have_gitlab_http_status(200)
+            expect(response).to have_gitlab_http_status(:ok)
           end
         end
       end
@@ -110,7 +110,7 @@
           get :index, params: { group_id: group, page: last_page.to_param }
           expect(assigns(:epics).current_page).to eq(last_page)
-          expect(response).to have_gitlab_http_status(200)
+          expect(response).to have_gitlab_http_status(:ok)
         end
         it_behaves_like 'disabled when using an external authorization service' do
@@ -216,7 +216,7 @@ def list_epics
           it 'the link to the issue is included' do
             get :discussions, params: { group_id: group, id: epic.to_param }
-            expect(response).to have_gitlab_http_status(200)
+            expect(response).to have_gitlab_http_status(:ok)
             expect(json_response.size).to eq(1)
             discussion = json_response[0]
             notes = discussion["notes"]
@@ -266,7 +266,7 @@ def show_epic(format = :html)
           it 'returns a not found 404 response' do
             show_epic
-            expect(response).to have_http_status(404)
+            expect(response).to have_gitlab_http_status(:not_found)
             expect(response.content_type).to eq 'text/html'
           end
         end
@@ -285,7 +285,7 @@ def show_epic(format = :html)
           group.add_developer(user)
           show_epic(:json)
-          expect(response).to have_http_status(200)
+          expect(response).to have_gitlab_http_status(:ok)
           expect(response).to match_response_schema('entities/epic', dir: 'ee')
         end
@@ -293,7 +293,7 @@ def show_epic(format = :html)
           it 'returns a not found 404 response' do
             show_epic(:json)
-            expect(response).to have_http_status(404)
+            expect(response).to have_gitlab_http_status(:not_found)
             expect(response.content_type).to eq 'application/json'
           end
         end
@@ -384,7 +384,7 @@ def update_epic(epic, params)
         it 'returns a not found 404 response' do
           subject
-          expect(response).to have_http_status(404)
+          expect(response).to have_gitlab_http_status(:not_found)
         end
       end
@@ -409,7 +409,7 @@ def update_epic(epic, params)
           it 'returns 200 response' do
             subject
-            expect(response).to have_http_status(200)
+            expect(response).to have_gitlab_http_status(:ok)
           end
           it 'creates a new epic' do
@@ -435,7 +435,7 @@ def update_epic(epic, params)
           end
           it 'returns 422 response' do
-            expect(response).to have_gitlab_http_status(422)
+            expect(response).to have_gitlab_http_status(:unprocessable_entity)
           end
           it 'does not create a new epic' do
@@ -449,7 +449,7 @@ def update_epic(epic, params)
           group.add_guest(user)
           subject
-          expect(response).to have_http_status(404)
+          expect(response).to have_gitlab_http_status(:not_found)
         end
       end
     end
@@ -463,14 +463,14 @@ def update_epic(epic, params)
         group.add_developer(user)
         delete :destroy, params: { group_id: group, id: epic.to_param, destroy_confirm: true }
-        expect(response).to have_gitlab_http_status(404)
+        expect(response).to have_gitlab_http_status(:not_found)
       end
       it "deletes the epic" do
         group.add_owner(user)
         delete :destroy, params: { group_id: group, id: epic.to_param, destroy_confirm: true }
-        expect(response).to have_gitlab_http_status(302)
+        expect(response).to have_gitlab_http_status(:found)
         expect(controller).to set_flash[:notice].to(/The epic was successfully deleted\./)
       end
     end

ee/spec/controllers/groups/group_members_controller_spec.rb

@@ -72,7 +72,7 @@
              },
              format: :js
-        expect(response).to have_gitlab_http_status(200)
+        expect(response).to have_gitlab_http_status(:ok)
       end
     end
   end

ee/spec/controllers/groups/groups_controller_spec.rb

@@ -88,7 +88,7 @@
       it 'prevents access to group resources' do
         get :show, params: { id: group }
-        expect(response).to have_gitlab_http_status(302)
+        expect(response).to have_gitlab_http_status(:found)
         expect(response.location).to match(/groups\/#{group.to_param}\/-\/saml\/sso\?redirect=.+&token=/)
       end
     end
@@ -103,7 +103,7 @@
       it 'allows access to group resources' do
         get :show, params: { id: group }
-        expect(response).to have_gitlab_http_status(200)
+        expect(response).to have_gitlab_http_status(:ok)
       end
     end
   end

ee/spec/controllers/groups/hooks_controller_spec.rb

@@ -20,7 +20,7 @@
       it 'is successfull' do
         get :index, params: { group_id: group.to_param }
-        expect(response).to have_gitlab_http_status(200)
+        expect(response).to have_gitlab_http_status(:ok)
       end
     end
@@ -43,7 +43,7 @@
         post :create, params: { group_id: group.to_param, hook: hook_params }
-        expect(response).to have_gitlab_http_status(302)
+        expect(response).to have_gitlab_http_status(:found)
         expect(group.hooks.size).to eq(1)
         expect(group.hooks.first).to have_attributes(hook_params)
       end
@@ -55,7 +55,7 @@
       it 'is successfull' do
         get :edit, params: { group_id: group.to_param, id: hook }
-        expect(response).to have_gitlab_http_status(200)
+        expect(response).to have_gitlab_http_status(:ok)
         expect(response).to render_template(:edit)
         expect(group.hooks.size).to eq(1)
       end
@@ -85,7 +85,7 @@
         it 'is successfull' do
           patch :update, params: { group_id: group.to_param, id: hook, hook: hook_params }
-          expect(response).to have_gitlab_http_status(302)
+          expect(response).to have_gitlab_http_status(:found)
           expect(response).to redirect_to(group_hooks_path(group))
           expect(group.hooks.size).to eq(1)
           expect(group.hooks.first).to have_attributes(hook_params)
@@ -102,7 +102,7 @@
         it 'renders "edit" template' do
           patch :update, params: { group_id: group.to_param, id: hook, hook: hook_params }
-          expect(response).to have_gitlab_http_status(200)
+          expect(response).to have_gitlab_http_status(:ok)
           expect(response).to render_template(:edit)
           expect(group.hooks.size).to eq(1)
           expect(group.hooks.first).not_to have_attributes(hook_params)
@@ -119,7 +119,7 @@
           post :test, params: { group_id: group.to_param, id: hook }
-          expect(response).to have_gitlab_http_status(302)
+          expect(response).to have_gitlab_http_status(:found)
           expect(flash[:alert]).to eq('Hook execution failed. Ensure the group has a project with commits.')
         end
       end
@@ -135,7 +135,7 @@
             post :test, params: { group_id: group.to_param, id: hook }
-            expect(response).to have_gitlab_http_status(302)
+            expect(response).to have_gitlab_http_status(:found)
             expect(flash[:notice]).to eq('Hook executed successfully: HTTP 200')
           end
         end
@@ -150,7 +150,7 @@
             post :test, params: { group_id: group.to_param, id: hook, trigger: trigger }
-            expect(response).to have_gitlab_http_status(302)
+            expect(response).to have_gitlab_http_status(:found)
             expect(flash[:notice]).to eq('Hook executed successfully: HTTP 200')
           end
         end
@@ -167,7 +167,7 @@
       it 'renders a 404' do
         get :index, params: { group_id: group.to_param }
-        expect(response).to have_gitlab_http_status(404)
+        expect(response).to have_gitlab_http_status(:not_found)
       end
     end
   end

ee/spec/controllers/groups/insights_controller_spec.rb

@@ -23,7 +23,7 @@
     it 'returns 404 status' do
       subject
-      expect(response).to have_gitlab_http_status(404)
+      expect(response).to have_gitlab_http_status(:not_found)
     end
   end
@@ -31,7 +31,7 @@
     it 'returns 200 status' do
       subject
-      expect(response).to have_gitlab_http_status(200)
+      expect(response).to have_gitlab_http_status(:ok)
     end
   end

ee/spec/controllers/groups/issues_analytics_controller_spec.rb

@@ -18,7 +18,7 @@
       it 'renders 404' do
         get :show, params: { group_id: group.to_param }
-        expect(response).to have_gitlab_http_status(404)
+        expect(response).to have_gitlab_http_status(:not_found)
       end
     end
@@ -32,7 +32,7 @@
       it 'renders 404' do
         get :show, params: { group_id: group.to_param }
-        expect(response).to have_gitlab_http_status(404)
+        expect(response).to have_gitlab_http_status(:not_found)
       end
     end

ee/spec/controllers/groups/issues_controller_spec.rb

@@ -31,7 +31,7 @@
       it 'returns 404 status' do
         subject
-        expect(response).to have_gitlab_http_status(404)
+        expect(response).to have_gitlab_http_status(:not_found)
       end
     end

ee/spec/controllers/groups/merge_requests_controller_spec.rb

@@ -35,7 +35,7 @@
       it 'returns 404 status' do
         subject
-        expect(response).to have_gitlab_http_status(404)
+        expect(response).to have_gitlab_http_status(:not_found)
       end
     end