Skip to content
Snippets Groups Projects
  1. Aug 23, 2021
  2. Aug 20, 2021
  3. Aug 19, 2021
  4. Aug 16, 2021
  5. Aug 13, 2021
  6. Aug 12, 2021
    • E'zeki&el Kigbo's avatar
      Update related specs · f896f449
      E'zeki&el Kigbo authored
      Fix jest base specs
      
      Updates the base vue js specs for
      project value stream analytics
      
      Update value stream metrics specs
      
      Added time metric fixtures for project vsa
      to generate relevant data
      
      Fix value stream metrics specs
      Unverified
      f896f449
  7. Aug 11, 2021
  8. Aug 02, 2021
  9. Jul 23, 2021
  10. Jul 21, 2021
  11. Jul 13, 2021
  12. Jul 12, 2021
  13. Jun 30, 2021
  14. Jun 29, 2021
  15. Jun 24, 2021
  16. Jun 22, 2021
  17. Jun 21, 2021
  18. Jun 18, 2021
  19. Jun 16, 2021
    • Alexis Kalderimis's avatar
      Deal with invalid caches · 56203843
      Alexis Kalderimis authored
      We need to manage some subtle caching edge cases. These are dealt with
      by:
      
      - Allowing clients to request a non-forgetful store
      - Abstracting over throttling of actions per-period. A new method is
        introduced: `ExclusiveLease.throttle` that takes care of such needs.
      - Allow specific keys to be forgotten after running policies
      - Invalidating the `CurrentUserMode` cache for `admin_mode` if the
        session-bypass is active (which may change the value).
      
      This deals with a very subtle cache collision problem. When this block
      is run, it calls the users update-service, which computes, during
      permission checks, the `admin` condition for this user. This is normally
      fine, but this callback is executed _before_ the bypass-session admin ID
      is set, which means that the cached value is stale during the execution
      of the main action.
      
      To avoid this, we deliberately discard the cached value of the `admin`
      condition, leaving all other cache values intact.
      
      Thankfully, `admin` is a cheap condition to recompute, and this does not
      cause any additional I/O to be run.
      
      Separately, the `Gitlab::Auth::CurrentUserMode` caches the value of
      `admin_mode`, which may become invalidated due to the session-bypass
      used for sessionless requests. We invalidate the cache when the
      session-bypass setting is changed.
      This invalidates the cached value for admin_mode, rather than requiring
      the caller to know when to force recomputation.
      
      A necessary change is made to prevent duplicate user-detail records.
      See: https://gitlab.com/gitlab-org/gitlab/-/issues/333245
      
      Changelog: fixed
      56203843
    • Himanshu Kapoor's avatar
      Add support for strikethrough in content editor · ed226820
      Himanshu Kapoor authored and David O'Regan's avatar David O'Regan committed
      ed226820
  20. Jun 15, 2021
  21. Jun 11, 2021
  22. Jun 09, 2021
  23. Jun 07, 2021
  24. Jun 03, 2021
  25. Jun 02, 2021
  26. Jun 01, 2021
  27. May 11, 2021
  28. Apr 26, 2021
  29. Apr 21, 2021
  30. Apr 20, 2021
Loading