Skip to content
Snippets Groups Projects
Commit 75dafce9 authored by John Carlson's avatar John Carlson
Browse files

Properly accept a merge request

parent 61a87926
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -12,11 +12,11 @@ import android.view.MenuItem;
import android.view.View;
import android.view.ViewGroup;
 
import com.commit451.easycallback.EasyCallback;
import com.commit451.easycallback.HttpException;
import com.commit451.gitlab.App;
import com.commit451.gitlab.R;
import com.commit451.gitlab.adapter.MergeRequestSectionsPagerAdapter;
import com.commit451.easycallback.EasyCallback;
import com.commit451.gitlab.api.GitLabFactory;
import com.commit451.gitlab.event.MergeRequestChangedEvent;
import com.commit451.gitlab.model.api.MergeRequest;
import com.commit451.gitlab.model.api.Project;
Loading
Loading
@@ -69,7 +69,14 @@ public class MergeRequestActivity extends BaseActivity {
public void failure(Throwable t) {
Timber.e(t, null);
mProgress.setVisibility(View.GONE);
Snackbar.make(mRoot, R.string.unable_to_merge, Snackbar.LENGTH_LONG)
String message = getString(R.string.unable_to_merge);
if (t instanceof HttpException) {
int code = ((HttpException) t).getCode();
if (code == 406) {
message = getString(R.string.merge_request_already_merged_or_closed);
}
}
Snackbar.make(mRoot, message, Snackbar.LENGTH_LONG)
.show();
}
};
Loading
Loading
Loading
Loading
@@ -260,7 +260,7 @@ public interface GitLab {
@Path("merge_request_id") long mergeRequestId,
@Field("body") String body);
 
@PUT(API_VERSION + "/projects/{id}/merge_requests/{merge_request_id}")
@PUT(API_VERSION + "/projects/{id}/merge_requests/{merge_request_id}/merge")
Call<MergeRequest> acceptMergeRequest(@Path("id") long projectId,
@Path("merge_request_id") long mergeRequestId);
 
Loading
Loading
Loading
Loading
@@ -327,6 +327,7 @@
</string-array>
<string name="created_merge_request">created merge request</string>
<string name="unable_to_merge">Unable to merge</string>
<string name="merge_request_already_merged_or_closed">Merge request has already been merged or closed</string>
<string name="merge_request_accepted">Merge request accepted</string>
 
<!-- Milestones -->
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment