Merge branch 'gitlab-renovate-forks/gitlab-renovate/gitlab-uisvg' into 'master'

Gitlab renovate forks/gitlab renovate/gitlab uisvg

See merge request gitlab-org/gitlab!62315

ee/spec/features/admin/admin_audit_logs_spec.rb

@@ -219,7 +219,7 @@ def filter_for(type, name)
       click_link type
       click_link name
-      find('button[type="button"]:not([name="clear"])').click
+      find('button[type="button"]:not([name="clear"]):not([aria-label="Close"]').click
     end
     wait_for_requests

ee/spec/frontend/analytics/code_review_analytics/components/__snapshots__/merge_request_table_spec.js.snap

@@ -142,6 +142,7 @@ exports[`MergeRequestTable component template matches the snapshot 1`] = `
                     aria-hidden="true"
                     class="mr-2 gl-icon s16"
                     data-testid="clock-icon"
+                    role="img"
                   >
                     <use
                       href="#clock"

ee/spec/frontend/analytics/cycle_analytics/components/__snapshots__/path_navigation_spec.js.snap

@@ -18,6 +18,7 @@ exports[`PathNavigation displays correctly loading is false matches the snapshot
         aria-hidden="true"
         class="gl-icon s32"
         data-testid="chevron-left-icon"
+        role="img"
       >
         <use
           href="#chevron-left"
@@ -40,6 +41,7 @@ exports[`PathNavigation displays correctly loading is false matches the snapshot
           aria-hidden="true"
           class="gl-mr-2 gl-icon s16"
           data-testid="gl-path-item-icon"
+          role="img"
         >
           <use
             href="#home"
@@ -407,6 +409,7 @@ exports[`PathNavigation displays correctly loading is false matches the snapshot
         aria-hidden="true"
         class="gl-icon s32"
         data-testid="chevron-right-icon"
+        role="img"
       >
         <use
           href="#chevron-right"

ee/spec/frontend/environments_dashboard/components/__snapshots__/environment_header_spec.js.snap

@@ -106,6 +106,7 @@ exports[`Environment Header renders name and link to app matches the snapshot 1`
         aria-hidden="true"
         class="fgray gl-icon s16"
         data-testid="external-link-icon"
+        role="img"
       >
         <use
           href="#external-link"

ee/spec/frontend/geo_nodes/components/node_detail_sections/__snapshots__/node_details_section_main_spec.js.snap

@@ -22,6 +22,7 @@ exports[`NodeDetailsSectionMain template node url section renders section correc
       aria-hidden="true"
       class="gl-ml-1 gl-icon s16"
       data-testid="external-link-icon"
+      role="img"
     >
       <use
         href="#external-link"

ee/spec/frontend/on_demand_scans/components/profile_selector/__snapshots__/scanner_profile_selector_spec.js.snap

@@ -68,6 +68,7 @@ exports[`OnDemandScansScannerProfileSelector renders properly with profiles 1`]
               aria-hidden="true"
               class="gl-button-icon dropdown-chevron gl-icon s16"
               data-testid="chevron-down-icon"
+              role="img"
             >
               <use
                 href="#chevron-down"
@@ -94,6 +95,7 @@ exports[`OnDemandScansScannerProfileSelector renders properly with profiles 1`]
                     aria-hidden="true"
                     class="gl-search-box-by-type-search-icon gl-icon s16"
                     data-testid="search-icon"
+                    role="img"
                   >
                     <use
                       href="#search"
@@ -134,6 +136,7 @@ exports[`OnDemandScansScannerProfileSelector renders properly with profiles 1`]
                       aria-hidden="true"
                       class="gl-icon s16 gl-new-dropdown-item-check-icon gl-mt-3 gl-align-self-start"
                       data-testid="dropdown-item-checkbox"
+                      role="img"
                     >
                       <use
                         href="#mobile-issue-close"
@@ -174,6 +177,7 @@ exports[`OnDemandScansScannerProfileSelector renders properly with profiles 1`]
                       aria-hidden="true"
                       class="gl-icon s16 gl-new-dropdown-item-check-icon gl-visibility-hidden gl-mt-3 gl-align-self-start"
                       data-testid="dropdown-item-checkbox"
+                      role="img"
                     >
                       <use
                         href="#mobile-issue-close"
@@ -302,6 +306,7 @@ exports[`OnDemandScansScannerProfileSelector renders properly with profiles 1`]
               aria-hidden="true"
               class="gl-button-icon gl-icon s16"
               data-testid="pencil-icon"
+              role="img"
             >
               <use
                 href="#pencil"

ee/spec/frontend/on_demand_scans/components/profile_selector/__snapshots__/site_profile_selector_spec.js.snap

@@ -68,6 +68,7 @@ exports[`OnDemandScansSiteProfileSelector renders properly with profiles 1`] = `
               aria-hidden="true"
               class="gl-button-icon dropdown-chevron gl-icon s16"
               data-testid="chevron-down-icon"
+              role="img"
             >
               <use
                 href="#chevron-down"
@@ -94,6 +95,7 @@ exports[`OnDemandScansSiteProfileSelector renders properly with profiles 1`] = `
                     aria-hidden="true"
                     class="gl-search-box-by-type-search-icon gl-icon s16"
                     data-testid="search-icon"
+                    role="img"
                   >
                     <use
                       href="#search"
@@ -134,6 +136,7 @@ exports[`OnDemandScansSiteProfileSelector renders properly with profiles 1`] = `
                       aria-hidden="true"
                       class="gl-icon s16 gl-new-dropdown-item-check-icon gl-mt-3 gl-align-self-start"
                       data-testid="dropdown-item-checkbox"
+                      role="img"
                     >
                       <use
                         href="#mobile-issue-close"
@@ -174,6 +177,7 @@ exports[`OnDemandScansSiteProfileSelector renders properly with profiles 1`] = `
                       aria-hidden="true"
                       class="gl-icon s16 gl-new-dropdown-item-check-icon gl-visibility-hidden gl-mt-3 gl-align-self-start"
                       data-testid="dropdown-item-checkbox"
+                      role="img"
                     >
                       <use
                         href="#mobile-issue-close"
@@ -302,6 +306,7 @@ exports[`OnDemandScansSiteProfileSelector renders properly with profiles 1`] = `
               aria-hidden="true"
               class="gl-button-icon gl-icon s16"
               data-testid="pencil-icon"
+              role="img"
             >
               <use
                 href="#pencil"

ee/spec/frontend/oncall_schedule/schedule/components/__snapshots__/rotations_list_section_spec.js.snap

@@ -35,6 +35,7 @@ exports[`RotationsListSectionComponent when the timeframe includes today renders
               aria-hidden="true"
               class="gl-button-icon gl-icon s16"
               data-testid="pencil-icon"
+              role="img"
             >
               <use
                 href="#pencil"
@@ -56,6 +57,7 @@ exports[`RotationsListSectionComponent when the timeframe includes today renders
               aria-hidden="true"
               class="gl-button-icon gl-icon s16"
               data-testid="remove-icon"
+              role="img"
             >
               <use
                 href="#remove"

ee/spec/frontend/security_dashboard/components/__snapshots__/unscanned_projects_spec.js.snap

@@ -44,6 +44,7 @@ exports[`UnscannedProjects component header matches the snapshot when the "helpP
         aria-hidden="true"
         class="align-top gl-icon s12"
         data-testid="question-icon"
+        role="img"
       >
         <use
           href="#question"

ee/spec/frontend/vue_shared/security_reports/components/__snapshots__/event_item_spec.js.snap

@@ -11,6 +11,7 @@ exports[`Event Item with action buttons renders the action buttons 1`] = `
       aria-hidden="true"
       class="gl-icon s16"
       data-testid="plus-icon"
+      role="img"
     >
       <use
         href="#plus"
@@ -92,6 +93,7 @@ exports[`Event Item with action buttons renders the action buttons 1`] = `
         aria-hidden="true"
         class="gl-button-icon gl-icon s16"
         data-testid="pencil-icon"
+        role="img"
       >
         <use
           href="#pencil"
@@ -112,6 +114,7 @@ exports[`Event Item with action buttons renders the action buttons 1`] = `
         aria-hidden="true"
         class="gl-button-icon gl-icon s16"
         data-testid="remove-icon"
+        role="img"
       >
         <use
           href="#remove"

package.json

@@ -53,7 +53,7 @@
     "@gitlab/favicon-overlay": "2.0.0",
     "@gitlab/svgs": "1.197.0",
     "@gitlab/tributejs": "1.0.0",
-    "@gitlab/ui": "29.28.0",
+    "@gitlab/ui": "29.29.2",
     "@gitlab/visual-review-tools": "1.6.1",
     "@rails/actioncable": "^6.0.3-4",
     "@rails/ujs": "^6.0.3-4",

spec/frontend/boards/components/__snapshots__/board_blocked_icon_spec.js.snap

 // Jest Snapshot v1, https://goo.gl/fbAQLP
 exports[`BoardBlockedIcon on mouseenter on blocked icon with more than three blocking issues matches the snapshot 1`] = `
-"<div class=\\"gl-display-inline\\"><svg data-testid=\\"issue-blocked-icon\\" aria-hidden=\\"true\\" class=\\"issue-blocked-icon gl-mr-2 gl-cursor-pointer gl-icon s16\\" id=\\"blocked-icon-uniqueId\\">
+"<div class=\\"gl-display-inline\\"><svg data-testid=\\"issue-blocked-icon\\" role=\\"img\\" aria-hidden=\\"true\\" class=\\"issue-blocked-icon gl-mr-2 gl-cursor-pointer gl-icon s16\\" id=\\"blocked-icon-uniqueId\\">
     <use href=\\"#issue-block\\"></use>
   </svg>
   <div class=\\"gl-popover\\">

spec/frontend/clusters/components/__snapshots__/remove_cluster_confirmation_spec.js.snap

@@ -62,6 +62,7 @@ exports[`Remove cluster confirmation modal renders splitbutton with modal includ
                 aria-hidden="true"
                 class="gl-icon s16 gl-new-dropdown-item-check-icon gl-mt-3 gl-align-self-start"
                 data-testid="dropdown-item-checkbox"
+                role="img"
               >
                 <use
                   href="#mobile-issue-close"
@@ -117,6 +118,7 @@ exports[`Remove cluster confirmation modal renders splitbutton with modal includ
                 aria-hidden="true"
                 class="gl-icon s16 gl-new-dropdown-item-check-icon gl-visibility-hidden gl-mt-3 gl-align-self-start"
                 data-testid="dropdown-item-checkbox"
+                role="img"
               >
                 <use
                   href="#mobile-issue-close"

spec/frontend/jira_import/components/__snapshots__/jira_import_form_spec.js.snap

@@ -73,6 +73,7 @@ exports[`JiraImportForm table body shows correct information in each cell 1`] =
           aria-label="Will be mapped to"
           class="gl-icon s16"
           data-testid="arrow-right-icon"
+          role="img"
         >
           <use
             href="#arrow-right"
@@ -109,6 +110,7 @@ exports[`JiraImportForm table body shows correct information in each cell 1`] =
               aria-hidden="true"
               class="gl-button-icon dropdown-chevron gl-icon s16"
               data-testid="chevron-down-icon"
+              role="img"
             >
               <use
                 href="#chevron-down"
@@ -135,6 +137,7 @@ exports[`JiraImportForm table body shows correct information in each cell 1`] =
                     aria-hidden="true"
                     class="gl-search-box-by-type-search-icon gl-icon s16"
                     data-testid="search-icon"
+                    role="img"
                   >
                     <use
                       href="#search"
@@ -198,6 +201,7 @@ exports[`JiraImportForm table body shows correct information in each cell 1`] =
           aria-label="Will be mapped to"
           class="gl-icon s16"
           data-testid="arrow-right-icon"
+          role="img"
         >
           <use
             href="#arrow-right"
@@ -234,6 +238,7 @@ exports[`JiraImportForm table body shows correct information in each cell 1`] =
               aria-hidden="true"
               class="gl-button-icon dropdown-chevron gl-icon s16"
               data-testid="chevron-down-icon"
+              role="img"
             >
               <use
                 href="#chevron-down"
@@ -260,6 +265,7 @@ exports[`JiraImportForm table body shows correct information in each cell 1`] =
                     aria-hidden="true"
                     class="gl-search-box-by-type-search-icon gl-icon s16"
                     data-testid="search-icon"
+                    role="img"
                   >
                     <use
                       href="#search"

spec/frontend/pages/projects/learn_gitlab/components/__snapshots__/learn_gitlab_a_spec.js.snap

@@ -92,6 +92,7 @@ exports[`Learn GitLab Design A renders correctly 1`] = `
                 aria-hidden="true"
                 class="gl-icon s16"
                 data-testid="completed-icon"
+                role="img"
               >
                 <use
                   href="#check-circle-filled"
@@ -114,6 +115,7 @@ exports[`Learn GitLab Design A renders correctly 1`] = `
                 aria-hidden="true"
                 class="gl-icon s16"
                 data-testid="completed-icon"
+                role="img"
               >
                 <use
                   href="#check-circle-filled"

spec/frontend/pages/projects/learn_gitlab/components/__snapshots__/learn_gitlab_b_spec.js.snap

@@ -81,6 +81,7 @@ exports[`Learn GitLab Design B renders correctly 1`] = `
               aria-hidden="true"
               class="gl-text-green-500 gl-icon s16"
               data-testid="completed-icon"
+              role="img"
             >
               <use
                 href="#check-circle-filled"
@@ -142,6 +143,7 @@ exports[`Learn GitLab Design B renders correctly 1`] = `
               aria-hidden="true"
               class="gl-text-green-500 gl-icon s16"
               data-testid="completed-icon"
+              role="img"
             >
               <use
                 href="#check-circle-filled"

spec/frontend/registry/explorer/components/__snapshots__/registry_breadcrumb_spec.js.snap

@@ -26,6 +26,7 @@ exports[`Registry Breadcrumb when is not rootRoute renders 1`] = `
         aria-hidden="true"
         class="gl-icon s8"
         data-testid="angle-right-icon"
+        role="img"
       >
         <use
           href="#angle-right"

spec/frontend/vue_shared/components/__snapshots__/awards_list_spec.js.snap

@@ -238,6 +238,7 @@ exports[`vue_shared/components/awards_list default matches snapshot 1`] = `
             aria-hidden="true"
             class="gl-icon s16"
             data-testid="slight-smile-icon"
+            role="img"
           >
             <use
               href="#slight-smile"
@@ -252,6 +253,7 @@ exports[`vue_shared/components/awards_list default matches snapshot 1`] = `
             aria-hidden="true"
             class="gl-icon s16"
             data-testid="smiley-icon"
+            role="img"
           >
             <use
               href="#smiley"
@@ -266,6 +268,7 @@ exports[`vue_shared/components/awards_list default matches snapshot 1`] = `
             aria-hidden="true"
             class="gl-icon s16"
             data-testid="smile-icon"
+            role="img"
           >
             <use
               href="#smile"

spec/frontend/vue_shared/components/__snapshots__/expand_button_spec.js.snap

@@ -14,6 +14,7 @@ exports[`Expand button on click when short text is provided renders button after
       aria-hidden="true"
       class="gl-button-icon gl-icon s16"
       data-testid="ellipsis_h-icon"
+      role="img"
     >
       <use
         href="#ellipsis_h"
@@ -43,6 +44,7 @@ exports[`Expand button on click when short text is provided renders button after
       aria-hidden="true"
       class="gl-button-icon gl-icon s16"
       data-testid="ellipsis_h-icon"
+      role="img"
     >
       <use
         href="#ellipsis_h"
@@ -67,6 +69,7 @@ exports[`Expand button when short text is provided renders button before text 1`
       aria-hidden="true"
       class="gl-button-icon gl-icon s16"
       data-testid="ellipsis_h-icon"
+      role="img"
     >
       <use
         href="#ellipsis_h"
@@ -96,6 +99,7 @@ exports[`Expand button when short text is provided renders button before text 1`
       aria-hidden="true"
       class="gl-button-icon gl-icon s16"
       data-testid="ellipsis_h-icon"
+      role="img"
     >
       <use
         href="#ellipsis_h"

spec/frontend/vue_shared/components/registry/__snapshots__/code_instruction_spec.js.snap

@@ -59,6 +59,7 @@ exports[`Package code instruction single line to match the default snapshot 1`]
             aria-hidden="true"
             class="gl-button-icon gl-icon s16"
             data-testid="copy-to-clipboard-icon"
+            role="img"
           >
             <use
               href="#copy-to-clipboard"