WIP

app/workers/repository_update_remote_mirror_worker.rb

@@ -18,10 +18,10 @@ class RepositoryUpdateRemoteMirrorWorker
       else
         remote_mirror.update_finish
       end
-    rescue => ex
-      remote_mirror.mark_as_failed("We're sorry, a temporary error occurred, please try again.")
-      raise UpdateRemoteMirrorError, "#{ex.class}: #{Gitlab::UrlSanitizer.sanitize(ex.message)}"
+    # rescue => ex
+    #   remote_mirror.mark_as_failed("We're sorry, a temporary error occurred, please try again.")
+    #   raise UpdateRemoteMirrorError, "#{ex.class}: #{Gitlab::UrlSanitizer.sanitize(ex.message)}"
     end
   end
 end

spec/factories/remote_mirrors.rb

+FactoryGirl.define do
+  factory :remote_mirror do
+  	url 'http://cantbeblank'
+  	project
+  end
+end
\ No newline at end of file

spec/models/remote_mirror_spec.rb

@@ -84,6 +84,17 @@ describe RemoteMirror do
     end
   end
+  context 'with missing project' do
+    it 'can be marked as failed' do
+      mirror = create(:remote_mirror)
+      mirror.update!(enabled: true, project_id: nil)
+
+      mirror.reload.mark_as_failed('missing project')
+
+      expect(mirror.reload.last_error).to eq 'missing project'
+    end
+  end
+
   def create_mirror(params)
     project = FactoryGirl.create(:project)
     project.remote_mirrors.create!(params)

spec/workers/repository_update_remote_mirror_worker_spec.rb

+require 'rails_helper'
+
+describe RepositoryUpdateRemoteMirrorWorker do
+  let(:mirror) { create(:remote_mirror) }
+
+  describe '#perform' do
+    it 'does nothing if project is missing' do
+      mirror.update!(project_id: nil)
+
+      expect(described_class.new.perform(mirror.id)).to be_nil
+    end
+  end
+end

spec/workers/update_all_remote_mirrors_worker_spec.rb

+require 'rails_helper'
+
+describe UpdateAllRemoteMirrorsWorker do
+  let(:worker) { described_class.new }
+
+  describe '#perform' do
+    context 'stuck mirrors' do
+      let!(:mirror) { create(:remote_mirror, update_status: :started, last_update_at: 1.week.ago) }
+
+      it 'are transitioned to failure state' do
+        worker.perform
+
+        expect(mirror.reload.update_status).to eq 'failed'
+      end
+
+      it 'handles enabled mirrors with missing project' do
+        mirror.update!(project: nil, enabled: true)
+
+        worker.perform
+
+        expect(mirror.reload.update_status).to eq 'failed'
+      end
+    end
+  end
+end