In the first implementation, we missed the usage of schedule's
cron syntax when calculating the next_run candidates.

Marius Bobin authored 3 years ago and Steve Abrams committed 3 years ago

Disable pipeline schedules when a user is blocked

Alishan Ladhani authored 4 years ago and Peter Leitzen committed 4 years ago

- In cases where `Timecop.freeze` is called with a
  specific time
- Only in spec directory

The plan for RSpec 4.0 is to disable monkey patching, reference:
https://rspec.info/blog/2013/07/the-plan-for-rspec-3/#zero-monkey-patching-mode
https://relishapp.com/rspec/rspec-core/docs/configuration/zero-monkey-patching-mode

This commit stops using RSpec monkey patching in several specs.

Using cop to find offences

Sean Carroll authored 4 years ago and Mayra Cabrera committed 4 years ago

Part of https://gitlab.com/gitlab-org/gitlab/-/issues/24295

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/29162

This moves all Plan, PlanLimits, Limitable
into CE.

This also makes the `Plan.default` or `Plan.free`
to always return a valid object.

This adds `Limitable` for `ProjectHook`
and `PipelineSchedules` on CE.

Jobs that could be scheduled from this cron worker:

- RunPipelineScheduleWorker
- BuildHooksWorker
- ExpireJobCacheWorker
- StageUpdateWorker
- PipelineUpdateWorker
- BuildQueueWorker
- ExpirePipelineCacheWorker
- PipelineHooksWorker
- PipelineProcessWorker
- Ci::BuildScheduleWorker
...

If pipeline schedule is to run at the exact same time with when cron
worker runs, the pipeline schedule will not be executed at the
ideal timing.

We fix this bug by comparing the exact matching of ideal and
cron worker's next run at.

Fixes flaky master

Also removes test from quarantine

See
https://gitlab.com/gitlab-org/gitlab-ce/issues/62760

Lin Jen-Shin authored 5 years ago and Nick Thomas committed 5 years ago

`Time.now` is local time, yet `Time.zone.now` is application
configuration time. They can be different.

Currently, pipeline schedule worker is unstable because it's
sometimes killed by excessive memory consumption.
In order to improve the performance, we add the following fixes:

1. next_run_at is always real_next_run, which means the value
   always takes into account of worker's cron schedule
1. Remove exlusive lock. This is already covered by real_next_run
   change.
1. Use RunPipelineScheduleWorker for avoiding memory killer.
   Memory consumption is spread to the multiple sidekiq worker.

This removes the warning when using Ruby 2.6:

BigDecimal.new is deprecated; use BigDecimal() method instead.

This also adds Rails 5 support, which eliminates the need for the monkey
patch to handle
https://github.com/thoughtbot/shoulda-matchers/issues/913.

CE port: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28443

Rails 5 requires that belongs_to associations have the associated record
present. These tests were failing because they had nil values.

Adds `# frozen_string_literal: true` to spec/models ruby files

This removes all usage of soft removals except for the "pending delete"
system implemented for projects. This in turn simplifies all the query
plans of the models that used soft removals. Since we don't really use
soft removals for anything useful there's no point in keeping it around.

This _does_ mean that hard removals of issues (which only admins can do
if I'm not mistaken) can influence the "iid" values, but that code is
broken to begin with. More on this (and how to fix it) can be found in
https://gitlab.com/gitlab-org/gitlab-ce/issues/31114.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37447

This removes all usage of soft removals except for the "pending delete"
system implemented for projects. This in turn simplifies all the query
plans of the models that used soft removals. Since we don't really use
soft removals for anything useful there's no point in keeping it around.

This _does_ mean that hard removals of issues (which only admins can do
if I'm not mistaken) can influence the "iid" values, but that code is
broken to begin with. More on this (and how to fix it) can be found in
https://gitlab.com/gitlab-org/gitlab-ce/issues/31114.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37447

Signed-off-by: Rémy Coutable <remy@rymai.me>

Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>