Remove `common.PORT` usage from `parallel` tests
- Version: master
- Platform: all
- Subsystem: test
Tests in parallel
that use common.PORT
risk getting EADDRINUSE
if another test in parallel
uses port 0
(to get an open port assigned by the operating system) at the same time the test runs. This appears to have happened recently. (See https://github.com/nodejs/node/pull/12363#issuecomment-293721140.)
IMO, all instances of common.PORT
in parallel
should either be changed to use port 0
(if possible in the context of the test) or else moved to sequential
(if using port 0
is not possible).
Here are the current tests that use common.PORT
:
-
test/parallel/test-cluster-basic.js (https://github.com/nodejs/node/pull/12377) -
test/parallel/test-cluster-bind-twice.js (https://github.com/nodejs/node/pull/12418) -
test/parallel/test-cluster-dgram-1.js (https://github.com/nodejs/node/pull/12487) -
test/parallel/test-cluster-dgram-2.js (https://github.com/nodejs/node/pull/12487) (https://github.com/nodejs/node/pull/12492) -
test/parallel/test-cluster-dgram-reuse.js (https://github.com/nodejs/node/pull/12901) -
test/parallel/test-cluster-disconnect-leak.js (https://github.com/nodejs/node/pull/12441) -
test/parallel/test-cluster-disconnect-race.js (https://github.com/nodejs/node/pull/12441) -
test/parallel/test-cluster-disconnect.js -
test/parallel/test-cluster-eaddrinuse.js -
test/parallel/test-cluster-inspector-debug-port.js -
test/parallel/test-cluster-ipc-throw.js -
test/parallel/test-cluster-master-error.js (https://github.com/nodejs/node/pull/12451) -
test/parallel/test-cluster-master-kill.js (https://github.com/nodejs/node/pull/12451) -
test/parallel/test-cluster-message.js -
test/parallel/test-cluster-net-send.js (https://github.com/nodejs/node/pull/12451) -
test/parallel/test-cluster-process-disconnect.js (https://github.com/nodejs/node/pull/12441) -
test/parallel/test-cluster-rr-domain-listen.js (https://github.com/nodejs/node/pull/12451) -
test/parallel/test-cluster-rr-ref.js (https://github.com/nodejs/node/pull/12451) -
test/parallel/test-cluster-send-deadlock.js (https://github.com/nodejs/node/pull/12472) -
test/parallel/test-cluster-send-handle-twice.js (https://github.com/nodejs/node/pull/12472) -
test/parallel/test-cluster-server-restart-none.js -
test/parallel/test-cluster-server-restart-rr.js -
test/parallel/test-cluster-shared-handle-bind-error.js -
test/parallel/test-cluster-shared-leak.js (https://github.com/nodejs/node/pull/12451) -
test/parallel/test-cluster-worker-disconnect-on-error.js (https://github.com/nodejs/node/pull/12457) -
test/parallel/test-cluster-worker-disconnect.js (#12443) -
test/parallel/test-cluster-worker-exit.js (#12443) -
test/parallel/test-cluster-worker-kill.js (#12443) -
test/parallel/test-cluster-worker-no-exit.js (https://github.com/nodejs/node/pull/12451) -
test/parallel/test-cluster-worker-wait-server-close.js (https://github.com/nodejs/node/pull/12466) -
test/parallel/test-debugger-repeat-last.js (#12470) -
test/parallel/test-dgram-bind-shared-ports.js (#12452) -
test/parallel/test-dgram-close-in-listening.js -
test/parallel/test-dgram-close-is-not-callback.js -
test/parallel/test-dgram-close.js -
test/parallel/test-dgram-exclusive-implicit-bind.js -
test/parallel/test-dgram-implicit-bind-failure.js -
test/parallel/test-dgram-oob-buffer.js -
test/parallel/test-dgram-send-address-types.js (https://github.com/nodejs/node/pull/13007) -
test/parallel/test-dgram-send-callback-buffer-empty-address.js (https://github.com/nodejs/node/pull/12929) -
test/parallel/test-dgram-send-callback-buffer-length-empty-address.js (https://github.com/nodejs/node/pull/12944) -
test/parallel/test-dgram-send-callback-buffer-length.js (https://github.com/nodejs/node/pull/12943) -
test/parallel/test-dgram-send-callback-buffer.js (https://github.com/nodejs/node/pull/12942) -
test/parallel/test-https-connect-address-family.js (#12915) -
test/parallel/test-net-better-error-messages-port-hostname.js (https://github.com/nodejs/node/pull/12473) -
test/parallel/test-net-better-error-messages-port.js -
test/parallel/test-net-connect-handle-econnrefused.js -
test/parallel/test-net-connect-immediate-destroy.js -
test/parallel/test-net-connect-immediate-finish.js -
test/parallel/test-net-connect-local-error.js -
test/parallel/test-net-listen-shared-ports.js -
test/parallel/test-net-localerror.js -
test/parallel/test-net-localport.js -
test/parallel/test-net-options-lookup.js -
test/parallel/test-net-reconnect-error.js -
test/parallel/test-net-server-bind.js (https://github.com/nodejs/node/pull/13273) -
test/parallel/test-net-socket-destroy-twice.js(https://github.com/nodejs/node/pull/12473) -
test/parallel/test-regress-GH-5051.js -
test/parallel/test-regress-GH-5727.js -
test/parallel/test-tls-client-abort.js (being worked on by @ahmed-taj
) (https://github.com/nodejs/node/pull/12461) -
test/parallel/test-tls-client-abort2.js (being worked on by @ahmed-taj
) (https://github.com/nodejs/node/pull/12461) -
test/parallel/test-tls-client-default-ciphers.js -
test/parallel/test-tls-connect.js -
test/parallel/test-tls-ticket-cluster.js