test: `common.expectsError()` is subtly broken
- Version: *
- Platform: *
- Subsystem: test
Ref: https://github.com/nodejs/node/pull/13623#discussion_r122003083
as reported by @cjihrig
:
common.expectsError()
is subtly broken. It relies oninstanceof
to check the error type. So aTypeError
is an instance ofError
, which is why this passed. The simplest fix might be to checkerror.constructor
inside ofcommon.expectsError()
. But that will require updating a bunch of tests because we're now using custom errors all over the place.