crypto test coverage - remaining blockers in crypto
Hi. I try to improve test coverage of internal/crypto.
Already I submitted pull requests that I can write test. #17555, #17458, #17449, #17447, #17426, #17418, #17728 and #17730.
I found two coverage blockers.
process.binding('crypto').PBKDF2
does not returns -1
1. Code
Reason
PBKDF2
returns undefined always because PBKDF2
returns anything.
See also:
So never match returns -1
.
ERR_CRYPTO_HASH_UPDATE_FAILED
2. Can't throw Code
Reason
Hash#_handle.update does not throw an Error(ERR_CRYPTO_HASH_UPDATE_FAILED).
Hash#_handle.update returns false when mdctx_
pointed at null.
But I could not reproduce mdctx_ make the null pointer.
1: I think should remove check where PBKDF2 returns -1.
2: Please teach me how to make mdctx_
to the null pointer.