Minor EventTarget correctness issues
I just noticed some very minor things while idly browsing recent node commits. /cc @benjamingr.
- Version: https://github.com/nodejs/node/commit/56e44601d285483ffe3c6efa3b80743900d84856
- Subsystem: events
Per Web IDL, EventTarget.prototype[Symbol.toStringTag]
should be a data property, not a getter. The commit above introduced it as a getter.
Note that url.js appears to do this correctly using the defineIDLClass
function, which perhaps should be shared.
- Version: https://github.com/nodejs/node/commit/2d071e767d95caddc9835e11cc2bd79c0548640d
- Subsystem: events
isTrusted
should not have a setter. It should only have a getter, since it is declared as a readonly
Web IDL attribute.