Merge branch '356478-fix-expired-artifact-factory' into 'master'

Fix failing expired artifact specs

See merge request gitlab-org/gitlab!83362

(cherry picked from commit 5e54d449)

57a6a430 Fix failing expired artifact specs
b13f5368 Fix timestamp precision comparison in test

spec/factories/ci/job_artifacts.rb

@@ -7,7 +7,7 @@ FactoryBot.define do
     file_format { :zip }
     trait :expired do
-      expire_at { Date.yesterday }
+      expire_at { Time.current.yesterday.change(minute: 9) }
     end
     trait :remote_store do

spec/models/ci/deleted_object_spec.rb

@@ -22,7 +22,7 @@ RSpec.describe Ci::DeletedObject, :aggregate_failures do
         expect(deleted_artifact.file_store).to eq(artifact.file_store)
         expect(deleted_artifact.store_dir).to eq(artifact.file.store_dir.to_s)
         expect(deleted_artifact.file_identifier).to eq(artifact.file_identifier)
-        expect(deleted_artifact.pick_up_at).to eq(artifact.expire_at)
+        expect(deleted_artifact.pick_up_at).to be_like_time(artifact.expire_at)
       end
     end