Merge branch 'dc-frontend-comment-clarifications' into 'master'

Clarified some frontend code comments

See merge request gitlab-org/gitlab!70225

app/assets/javascripts/blob/blob_file_dropzone.js

@@ -31,7 +31,6 @@ export default class BlobFileDropzone {
       autoProcessQueue: false,
       url: form.attr('action'),
       // Rails uses a hidden input field for PUT
-      // http://stackoverflow.com/questions/21056482/how-to-set-method-put-in-form-tag-in-rails
       method,
       clickable: true,
       uploadMultiple: false,

app/assets/javascripts/lib/utils/common_utils.js

@@ -117,7 +117,6 @@ export const handleLocationHash = () => {
 };
 // Check if element scrolled into viewport from above or below
-// Courtesy http://stackoverflow.com/a/7557433/414749
 export const isInViewport = (el, offset = {}) => {
   const rect = el.getBoundingClientRect();
   const { top, left } = offset;
@@ -560,8 +559,6 @@ export const addSelectOnFocusBehaviour = (selector = '.js-select-on-focus') => {
  * Method to round of values with decimal places
  * with provided precision.
  *
- * Taken from https://stackoverflow.com/a/7343013/414749
- *
  * Eg; roundOffFloat(3.141592, 3) = 3.142
  *
  * Refer to spec/frontend/lib/utils/common_utils_spec.js for

app/assets/javascripts/milestones/components/milestone_combobox.vue

@@ -125,8 +125,7 @@ export default {
     // This method is defined here instead of in `methods`
     // because we need to access the .cancel() method
     // lodash attaches to the function, which is
-    // made inaccessible by Vue. More info:
-    // https://stackoverflow.com/a/52988020/1063392
+    // made inaccessible by Vue.
     this.debouncedSearch = debounce(function search() {
       this.search(this.searchQuery);
     }, SEARCH_DEBOUNCE_MS);

app/assets/javascripts/ref/components/ref_selector.vue

@@ -149,8 +149,7 @@ export default {
     // This method is defined here instead of in `methods`
     // because we need to access the .cancel() method
     // lodash attaches to the function, which is
-    // made inaccessible by Vue. More info:
-    // https://stackoverflow.com/a/52988020/1063392
+    // made inaccessible by Vue.
     this.debouncedSearch = debounce(function search() {
       this.search();
     }, SEARCH_DEBOUNCE_MS);

app/assets/javascripts/rest_api.js

@@ -4,7 +4,7 @@ export * from './api/user_api';
 export * from './api/markdown_api';
 // Note: It's not possible to spy on methods imported from this file in
-// Jest tests. See https://stackoverflow.com/a/53307822/1063392.
+// Jest tests.
 // As a workaround, in Jest tests, import the methods from the file
 // in which they are defined:
 //

app/assets/javascripts/sentry/sentry_config.js

@@ -19,7 +19,6 @@ const IGNORE_ERRORS = [
   'fb_xd_fragment',
   // ISP "optimizing" proxy - `Cache-Control: no-transform` seems to
   // reduce this. (thanks @acdha)
-  // See http://stackoverflow.com/questions/4113268
   'bmi_SafeAddOnload',
   'EBCallBackMessageReceived',
   // See http://toolbar.conduit.com/Developer/HtmlAndGadget/Methods/JSInjection.aspx

app/assets/javascripts/static_site_editor/rich_content_editor/services/renderers/render_identifier_instance_text.js

@@ -18,7 +18,7 @@ Regexp notes:
 const identifierInstanceRegex = /((?:\[.+?\]){1}(?:\[\]|\[.+?\])?(?!:))/g;
 const isIdentifierInstance = (literal) => {
-  // Reset lastIndex as global flag in regexp are stateful (https://stackoverflow.com/a/11477448)
+  // Reset lastIndex as global flag in regexp are stateful
   identifierInstanceRegex.lastIndex = 0;
   return identifierInstanceRegex.test(literal);
 };

app/assets/stylesheets/framework/variables.scss

@@ -505,7 +505,7 @@ $line-removed-dark: #fac5cd !default;
  * would hide other layers (selected text, matching brackets).
  *
  * When the transparent colors get layered on white background, they create their
- * full opacity counterparts (computed with https://stackoverflow.com/a/12228643/606571):
+ * full opacity counterparts:
  *
  *  - white + $line-added-transparent = $line-added
  *  - white + $line-added-transparent + $line-added-dark-transparent = $line-added-dark

app/assets/stylesheets/mailer.scss

 @import 'framework/variables';
 // Do not use 3-letter hex codes, bgcolor vs css background-color is problematic in emails
-// See https://stackoverflow.com/questions/28551981/why-are-3-digit-hex-color-code-values-interpreted-differently-in-internet-explor
 //
 // stylelint-disable color-hex-length

app/assets/stylesheets/page_bundles/merge_requests.scss

@@ -40,7 +40,7 @@
   position: -webkit-sticky;
   position: sticky;
-  // Unitless zero values are not allowed in calculations https://stackoverflow.com/a/55391061
+  // Unitless zero values are not allowed in calculations
   // stylelint-disable-next-line length-zero-no-unit
   top: calc(#{$top-pos} + var(--system-header-height, 0px) + var(--performance-bar-height, 0px));
   // stylelint-disable-next-line length-zero-no-unit

spec/frontend/__helpers__/local_storage_helper.js

@@ -2,9 +2,7 @@
  * Manage the instance of a custom `window.localStorage`
  *
  * This only encapsulates the setup / teardown logic so that it can easily be
- * reused with different implementations (i.e. a spy or a [fake][1])
- *
- * [1]: https://stackoverflow.com/a/41434763/1708147
+ * reused with different implementations (i.e. a spy or a fake)
  *
  * @param {() => any} fn Function that returns the object to use for localStorage
  */

spec/frontend/__helpers__/mock_window_location_helper.js

@@ -2,9 +2,7 @@
  * Manage the instance of a custom `window.location`
  *
  * This only encapsulates the setup / teardown logic so that it can easily be
- * reused with different implementations (i.e. a spy or a [fake][1])
- *
- * [1]: https://stackoverflow.com/a/41434763/1708147
+ * reused with different implementations (i.e. a spy or a fake)
  *
  * @param {() => any} fn Function that returns the object to use for window.location
  */

spec/frontend/shortcuts_spec.js

@@ -70,8 +70,7 @@ describe('Shortcuts', () => {
           const mdShortcuts = $(this).data('md-shortcuts');
           // jQuery.map() automatically unwraps arrays, so we
-          // have to double wrap the array to counteract this:
-          // https://stackoverflow.com/a/4875669/1063392
+          // have to double wrap the array to counteract this
           return mdShortcuts ? [mdShortcuts] : undefined;
         })
         .get();