Skip to content
Snippets Groups Projects
Commit 18207030 authored by Derrick Stolee's avatar Derrick Stolee Committed by Junio C Hamano
Browse files

commit: use timestamp_t for author_date_slab


The author_date_slab is used to store the author date of a commit
when walking with the --author-date flag in rev-list or log. This
was added as an 'unsigned long' in

	81c6b38b "log: --author-date-order"

Since 'unsigned long' is ambiguous in its bit-ness across platforms
(64-bit in Linux, 32-bit in Windows, for example), most references
to the author dates in commit.c were converted to timestamp_t in

	dddbad72 "timestamp_t: a new data type for timestamps"

However, the slab definition was missed, leading to a mismatch in
the data types in Windows. This would not reveal itself as a bug
unless someone authors a commit after February 2106, but commits
can store anything as their author date.

Signed-off-by: default avatarDerrick Stolee <dstolee@microsoft.com>
Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
parent 5589e87f
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -588,7 +588,7 @@ struct commit *pop_commit(struct commit_list **stack)
define_commit_slab(indegree_slab, int);
 
/* record author-date for each commit object */
define_commit_slab(author_date_slab, unsigned long);
define_commit_slab(author_date_slab, timestamp_t);
 
static void record_author_date(struct author_date_slab *author_date,
struct commit *commit)
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment