Skip to content
Snippets Groups Projects
Commit b89b4a66 authored by SZEDER Gábor's avatar SZEDER Gábor Committed by Junio C Hamano
Browse files

t6018-rev-list-glob: fix 'empty stdin' test


Prior to d3c6751b (tests: make use of the test_must_be_empty
function, 2018-07-27), in the test 'rev-list should succeed with empty
output on empty stdin' in 't6018-rev-list-glob' the empty 'expect'
file served dual purpose: besides specifying the expected output, as
usual, it also served as empty input for 'git rev-list --stdin'.

Then d3c6751b came along, and, as part of the conversion to
'test_must_be_empty', removed this empty 'expect' file, not realizing
its secondary purpose.  Redirecting stdin from the now non-existing
file failed the test, but since this test expects failure in the first
place, this issue went unnoticed.

Redirect 'git rev-list's stdin explicitly from /dev/null to provide
empty input.  (Strictly speaking we don't need this redirection,
because the test script's stdin is already redirected from /dev/null
anyway, but I think it's better to be explicit about it.)

Signed-off-by: default avatarSZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
parent d3c6751b
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -256,7 +256,7 @@ test_expect_success 'rev-list accumulates multiple --exclude' '
'
 
test_expect_failure 'rev-list should succeed with empty output on empty stdin' '
git rev-list --stdin <expect >actual &&
git rev-list --stdin </dev/null >actual &&
test_must_be_empty actual
'
 
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment