Skip to content
Snippets Groups Projects
  1. Mar 22, 2018
  2. Feb 27, 2018
    • Junio C Hamano's avatar
      Merge branch 'ys/bisect-object-id-missing-conversion-fix' into maint · 38e79b1f
      Junio C Hamano authored
      Fix for a commented-out code to adjust it to a rather old API change.
      
      * ys/bisect-object-id-missing-conversion-fix:
        bisect: debug: convert struct object to object_id
      38e79b1f
    • Junio C Hamano's avatar
      Merge branch 'sb/submodule-update-reset-fix' into maint · 14890e91
      Junio C Hamano authored
      When resetting the working tree files recursively, the working tree
      of submodules are now also reset to match.
      
      * sb/submodule-update-reset-fix:
        submodule: submodule_move_head omits old argument in forced case
        unpack-trees: oneway_merge to update submodules
        t/lib-submodule-update.sh: fix test ignoring ignored files in submodules
        t/lib-submodule-update.sh: clarify test
      14890e91
    • Junio C Hamano's avatar
      Merge branch 'ab/commit-m-with-fixup' into maint · c1ab3b8a
      Junio C Hamano authored
      "git commit --fixup" did not allow "-m<message>" option to be used
      at the same time; allow it to annotate resulting commit with more
      text.
      
      * ab/commit-m-with-fixup:
        commit: add support for --fixup <commit> -m"<extra message>"
        commit doc: document that -c, -C, -F and --fixup with -m error
      c1ab3b8a
    • Junio C Hamano's avatar
      Merge branch 'nd/ita-wt-renames-in-status' into maint · 12accdc0
      Junio C Hamano authored
      "git status" after moving a path in the working tree (hence making
      it appear "removed") and then adding with the -N option (hence
      making that appear "added") detected it as a rename, but did not
      report the  old and new pathnames correctly.
      
      * nd/ita-wt-renames-in-status:
        wt-status.c: handle worktree renames
        wt-status.c: rename rename-related fields in wt_status_change_data
        wt-status.c: catch unhandled diff status codes
        wt-status.c: coding style fix
        Use DIFF_DETECT_RENAME for detect_rename assignments
        t2203: test status output with porcelain v2 format
      12accdc0
  3. Feb 22, 2018
    • Motoki Seki's avatar
      Documentation/gitsubmodules.txt: avoid non-ASCII apostrophes · 13164169
      Motoki Seki authored
      In gitsubmodules.txt, a few non-ASCII apostrophes are used to spell
      possessive, e.g. "submodule's".  These unfortunately are not
      rendered at https://git-scm.com/docs/gitsubmodules
      
       correctly by the
      renderer used there.
      
      Use ASCII apostrophes instead to work around the problem.  It also
      is good to be consistent, as there are possessives spelled with
      ASCII apostrophes.
      
      Signed-off-by: default avatarMotoki Seki <marmot.motoki@gmail.com>
      Acked-by: default avatarStefan Beller <sbeller@google.com>
      Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
      13164169
    • Jeff King's avatar
      revision: drop --show-all option · f74bbc8d
      Jeff King authored
      
      This was an undocumented debugging aid that does not seem to
      have come in handy in the past decade, judging from its lack
      of mentions on the mailing list.
      
      Let's drop it in the name of simplicity. This is morally a
      revert of 3131b713 (Add "--show-all" revision walker flag
      for debugging, 2008-02-09), but note that I did leave in the
      mapping of UNINTERESTING to "^" in get_revision_mark(). I
      don't think this would be possible to trigger with the
      current code, but it's the only sensible marker.
      
      We'll skip the usual deprecation period because this was
      explicitly a debugging aid that was never documented.
      
      Signed-off-by: default avatarJeff King <peff@peff.net>
      Acked-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
      f74bbc8d
    • Jeff King's avatar
      commit: drop uses of get_cached_commit_buffer() · 7fa31b64
      Jeff King authored
      
      The "--show-all" revision option shows UNINTERESTING
      commits. Some of these commits may be unparsed when we try
      to show them (since we may or may not need to walk their
      parents to fulfill the request).
      
      Commit 3131b713 (Add "--show-all" revision walker flag for
      debugging, 2008-02-09) resolved this by just skipping
      pretty-printing for commits without their object contents
      cached, saying:
      
        Because we now end up listing commits we may not even have been parsed
        at all "show_log" and "show_commit" need to protect against commits
        that don't have a commit buffer entry.
      
      That was the easy fix to avoid the pretty-printer segfaulting,
      but:
      
        1. It doesn't work for all formats. E.g., --oneline
           prints the oid for each such commit but not a trailing
           newline, leading to jumbled output.
      
        2. It only affects some commits, depending on whether we
           happened to parse them or not (so if they were at the
           tip of an UNINTERESTING starting point, or if we
           happened to traverse over them, you'd see more data).
      
        3. It unncessarily ties the decision to show the verbose
           header to whether the commit buffer was cached. That
           makes it harder to change the logic around caching
           (e.g., if we could traverse without actually loading
           the full commit objects).
      
      These days it's safe to feed such a commit to the
      pretty-print code. Since be5c9fb9 (logmsg_reencode: lazily
      load missing commit buffers, 2013-01-26), we'll load it on
      demand in such a case. So let's just always show the verbose
      headers.
      
      This does change the behavior of plumbing, but:
      
        a. The --show-all option was explicitly introduced as a
           debugging aid, and was never documented (and has rarely
           even been mentioned on the list by git devs).
      
        b. Avoiding the commits was already not deterministic due
           to (2) above. So the caller might have seen full
           headers for these commits anyway, and would need to be
           prepared for it.
      
      Signed-off-by: default avatarJeff King <peff@peff.net>
      Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
      7fa31b64
Loading