Skip to content
Snippets Groups Projects
Commit 4ae62d33 authored by Douwe Maan's avatar Douwe Maan
Browse files

Merge branch 'rs-note-model-cleanup' into 'master'

Minor Note model cleanup

Remove `Note#noteable_type_name`

This method was added in Dec 2012, its single use was removed two days
later, and it's been there ever since.

---

Remove `Note#system?` "override"

This method was duplicating default Rails behavior.

See merge request !3104

Former-commit-id: 20ed08ed
parents 9cdab5bb d1f1ba65
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -323,10 +323,6 @@ class Note < ActiveRecord::Base
noteable
end
 
def noteable_type_name
noteable_type.downcase if noteable_type.present?
end
# FIXME: Hack for polymorphic associations with STI
# For more information visit http://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#label-Polymorphic+Associations
def noteable_type=(noteable_type)
Loading
Loading
@@ -346,10 +342,6 @@ class Note < ActiveRecord::Base
Event.reset_event_cache_for(self)
end
 
def system?
read_attribute(:system)
end
def downvote?
is_award && note == "thumbsdown"
end
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment