Merge branch 'say-bye-bye-nicescroll' into 'master'

Removes nicescroll from issuable sidebar

See merge request !10831

app/assets/javascripts/boards/components/board_sidebar.js

@@ -59,18 +59,6 @@ gl.issueBoards.BoardSidebar = Vue.extend({
       },
       deep: true
     },
-    issue () {
-      if (this.showSidebar) {
-        this.$nextTick(() => {
-          $('.right-sidebar').getNiceScroll(0).doScrollTop(0, 0);
-          $('.right-sidebar').getNiceScroll().resize();
-        });
-      }
-
-      this.issue = this.detail.issue;
-      this.list = this.detail.list;
-    },
-    deep: true
   },
   methods: {
     closeSidebar () {

app/assets/javascripts/issuable_context.js

@@ -47,7 +47,6 @@ import UsersSelect from './users_select';
           Cookies.set('collapsed_gutter', true);
         }
       });
-      $(".right-sidebar").niceScroll();
     }
     IssuableContext.prototype.initParticipants = function() {

app/assets/stylesheets/pages/issuable.scss

@@ -197,6 +197,15 @@
   background: $gray-light;
   padding: 10px 20px;
   z-index: 200;
+  overflow: hidden;
+
+  .issuable-sidebar {
+    width: calc(100% + 100px);
+    height: 100%;
+    overflow-y: scroll;
+    overflow-x: hidden;
+    -webkit-overflow-scrolling: touch;
+  }
   &.right-sidebar-expanded {
     width: $gutter_width;