"Permission denied" error should be ignored when attempting to hash files for Commit
We have a SQL Server database checked into our repository against which we run our tests. When the tests are run they automatically attach/mount this database to a local instance of SQL Server Express. SQL Server then locks the mounted database files (.mdf and .ldf) to prevent any program from deleting those files from under it.
This causes a problem for TortoiseGit, because when attempting to commit, it scans all files in the repository to figure out if they're changed, and when it gets to these locked files, it cannot access them. Thus it throws up this lovely dialog:
Thee are 2 problems with this dialog:
- It's unnecessary - I know the file is locked and I don't care. I don't want to have to click "OK" to a useless error dialog every damn time the Commit window refreshes.
- Although it appears to correctly have the Commit window set as its parent, this dialog doesn't always appear on top of that window. Sometimes it appears behind it, and because it blocks the Commit window, I have to go hunting through my open windows until I find the error dialog, then close it.
The best part is that after I dismiss this dialog, the changed .mdf and .ldf files ARE displayed in the Commit window...
Suggested fixes:
Unconditionally suppress this dialog.
If that's not desirable, add a UI option to allow it to be suppressed, and fix its z-index behaviour. Further, make the dialog non-blocking so that it does not prevent the Commit window from refreshing.
What version of TortoiseGit and Git are you using? On what operating system?
- TortoiseGit 2.5.0.0 (C:\Program Files\TortoiseGit\bin)
- git version 2.13.0.windows.1 (C:\Program Files\Git\bin; C:\Program Files\Git\mingw64; C:\Program Files\Git\mingw64\etc\gitconfig; C:\ProgramData\Git\config)
- Windows 10 Enterprise x64 (version 1703 build 15063.483)